Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform indexing: validate carbon.yml against the storybook - ensure no discrepancies #12948

Closed
2 tasks done
Tracked by #12933
tay1orjones opened this issue Jan 10, 2023 · 3 comments · Fixed by #12988
Closed
2 tasks done
Tracked by #12933

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jan 10, 2023

This issue is ensure that content available on the storybook has parity with what's consumed and available on Platform.

#12948 (comment)

@francinelucca
Copy link
Collaborator

francinelucca commented Jan 11, 2023

Content-Sync:

Thumbnails:

  • Read-only state patterns
  • Form Label
  • IdPrefix

@francinelucca
Copy link
Collaborator

francinelucca commented Jan 12, 2023

TODO:

indexed

Taylor advised no need to index

REMOVE or Add SB?

  • indexed hooks: useTheme, unstable_useLayoutDirection, unstable_useFeatureFlags, unstable_useFeatureFlag, unstable_useContextMenu

indexed SB foruseTheme, no further action needed for others

indexed SB for layoutDirection, no further action needed for hook

removed from index as is a subcomponent of heading and we're not indexing subcomponents

indexed storybook, no further action needed

@francinelucca
Copy link
Collaborator

francinelucca commented Jan 18, 2023

TODO:

  • thumbnails
  • angular/svelte DefinitionTooltip pr
  • confirm tags with Aubrey
  • confirm fluid variants with Anna
  • test content parity
  • Add testing data to PR

@tay1orjones tay1orjones moved this from ⏱ Backlog to 🏗 In Progress in Design System Jan 26, 2023
@francinelucca francinelucca moved this from 🏗 In Progress to 🚦 In Review in Design System Feb 3, 2023
@kodiakhq kodiakhq bot closed this as completed in #12988 Feb 9, 2023
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants