Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update List accessibility.mdx #2975

Merged
merged 12 commits into from
Jun 17, 2022
Merged

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Jun 6, 2022

Updating the information on the accessibility tab of list to the new template and content.

Addresses content evaluated in https://ibm.box.com/s/94q54gsl3tac5hf51hr4h93n7aogryxn

Updating the information on the accessibility tab of list to the new template and content.
@mbgower mbgower requested review from a team as code owners June 6, 2022 14:23
@mbgower mbgower requested review from abbeyhrt, dakahn and aagonzales June 6, 2022 14:23
@vercel
Copy link

vercel bot commented Jun 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
carbondesignsystem ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 9:34PM (UTC)

removed capitals on 'assistive technologies' and provides a link to screen reader
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two formatting bugs

src/pages/components/list/accessibility.mdx Outdated Show resolved Hide resolved
src/pages/components/list/accessibility.mdx Outdated Show resolved Hide resolved
mbgower and others added 2 commits June 6, 2022 14:48
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@dakahn
Copy link
Contributor

dakahn commented Jun 8, 2022

pushed a prettier fix @mbgower -- CI should be good now 👍🏾

@mbgower
Copy link
Contributor Author

mbgower commented Jun 9, 2022

Thanks, @dakahn! I'm editing this straight from the page and doing minor word changes, so not sure how I'm triggering a failure check.

[HTML](https://www.w3.org/WAI/tutorials/page-structure/content/#lists) ordered
(`ol`) and unorder (`ul`) lists and list items (`li`), then styles them with
CSS.
- Carbon uses `::before` and `::marker` CSS pseudo-elements for the numbering
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing a weird line break here in the last bullet

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what's going on there. The line breaks shouldn't matter in an mdx file. I've stripped them right out and made each of the last 2 bullets all run on a single line each. @tay1orjones if this doesn't resolve, maybe you can figure out what the issue is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a bug with the list item implementation. I'll work on a fix

tried moving last two bullets onto single lines
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbgower @aagonzales I have a fix for the link spacing issue coming in #2996.

We can merge this as-is if you'd like, that PR will fix it once it's in.

@kodiakhq kodiakhq bot merged commit 6d57e53 into carbon-design-system:main Jun 17, 2022
@mbgower mbgower changed the title Update accessibility.mdx Update List accessibility.mdx Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants