-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update List accessibility.mdx #2975
Conversation
Updating the information on the accessibility tab of list to the new template and content.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
removed capitals on 'assistive technologies' and provides a link to screen reader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just two formatting bugs
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
pushed a prettier fix @mbgower -- CI should be good now 👍🏾 |
Thanks, @dakahn! I'm editing this straight from the page and doing minor word changes, so not sure how I'm triggering a failure check. |
[HTML](https://www.w3.org/WAI/tutorials/page-structure/content/#lists) ordered | ||
(`ol`) and unorder (`ul`) lists and list items (`li`), then styles them with | ||
CSS. | ||
- Carbon uses `::before` and `::marker` CSS pseudo-elements for the numbering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea what's going on there. The line breaks shouldn't matter in an mdx file. I've stripped them right out and made each of the last 2 bullets all run on a single line each. @tay1orjones if this doesn't resolve, maybe you can figure out what the issue is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have a bug with the list item implementation. I'll work on a fix
tried moving last two bullets onto single lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbgower @aagonzales I have a fix for the link spacing issue coming in #2996.
We can merge this as-is if you'd like, that PR will fix it once it's in.
Updating the information on the accessibility tab of list to the new template and content.
Addresses content evaluated in https://ibm.box.com/s/94q54gsl3tac5hf51hr4h93n7aogryxn