feat: add data viz section to website #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP] Charts
…nto data-viz # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…nto charts # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
WIP - Charts
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://carbon-website-git-data-viz.carbon-design-system.now.sh |
|
This all looks good to me! (I can't officially approve since its technically my PR). One comment, did we want to add a link/card to Carbon-charts on the Resources page? |
shixiedesign
approved these changes
Oct 2, 2019
jnm2377
reviewed
Oct 2, 2019
Comment on lines
+54
to
+55
| top: -1px; | ||
| left: -1px; |
There was a problem hiding this comment.
Do we want to use our rem() function here?
Co-Authored-By: Jen Downs <hello@jendowns.com>
jnm2377
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Data Visualization section to site
closes: #240, #241, #364, #242, #243, #387, #351
Dev review instructions
A ton of files added because we are adding a whole new section to the left nav. A lot of them are images so do not need review. Please verify all the components used in the data viz pages are working:
Basic chartsandAdvanced chartspageWe don't expect dev review to go into the content, but obviously if you see a problem with content, definitely tell us. Any additional feedback welcomed!
Design review instructions
TBD - working with Mike in person on this at the moment.
Content review instructions
FYI @connor-leech @janchild