Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update color page tokens #2840

Merged
merged 5 commits into from
Mar 31, 2022
Merged

feat: update color page tokens #2840

merged 5 commits into from
Mar 31, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Mar 31, 2022

Closes #2754

Changelog

  • updates color token names
  • adds new tokens

@jnm2377 jnm2377 requested a review from aagonzales March 31, 2022 00:49
@jnm2377 jnm2377 requested review from a team as code owners March 31, 2022 00:49
@jnm2377 jnm2377 requested review from tay1orjones and abbeyhrt March 31, 2022 00:49
@vercel
Copy link

vercel bot commented Mar 31, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/9W9LC5m28EPGFNLCpVfejHbAHQm6
✅ Preview: https://carbondesignsystem-git-fork-jnm2377-461f16-carbon-design-system.vercel.app

aagonzales
aagonzales approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to do a bit of a partial approval to get this in for tomorrow (today?). The token names and values looked good from a high level pass. Some of the Roles need some updates but we can do that in another PR later.

@kodiakhq kodiakhq bot merged commit 4ff0c98 into carbon-design-system:v11 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@abbeyhrt abbeyhrt Awaiting requested review from abbeyhrt abbeyhrt is a code owner automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnm2377 @tay1orjones @aagonzales