Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Charts #257

Merged
merged 149 commits into from
Sep 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
149 commits
Select commit Hold shift + click to select a range
5405b70
docs: migrated pattern
connor-leech Aug 21, 2019
24a5c9e
Merge branch 'master' into creation-flows
connor-leech Aug 21, 2019
d69b915
fix: multiple bug fixes
alisonjoseph Aug 23, 2019
e468c20
docs: typos
connor-leech Aug 23, 2019
9ced290
Merge branch 'master' into bug-fixes
vpicone Aug 26, 2019
073a9c7
Merge branch 'master' into bug-fixes
alisonjoseph Aug 27, 2019
50c3f66
Merge branch 'master' into bug-fixes
alisonjoseph Aug 27, 2019
5736769
Merge branch 'master' into creation-flows
connor-leech Aug 28, 2019
79f9a49
docs: link to experimental
connor-leech Aug 28, 2019
4064bea
docs: import modal
connor-leech Aug 28, 2019
431dbe1
docs: migrated removing pattern
connor-leech Aug 28, 2019
eca452c
docs: typo fix
connor-leech Aug 29, 2019
ce1eb85
docs: small fixes, no fold references
connor-leech Aug 29, 2019
49d365c
docs: forgot to stage
connor-leech Aug 29, 2019
06b2470
docs: generating an API pattern
connor-leech Aug 29, 2019
ee99830
docs: removed tabs
connor-leech Aug 29, 2019
a7f4f09
docs: tweak
connor-leech Aug 29, 2019
52e7294
Merge branch 'master' into bug-fixes
alisonjoseph Sep 3, 2019
3c806af
Merge branch 'creation-flows' of https://github.com/connor-leech/carb…
connor-leech Sep 3, 2019
6eb9193
Merge branch 'connor-leech-creation-flows'
connor-leech Sep 3, 2019
c83ae00
docs: some small changes
connor-leech Sep 3, 2019
fe2df8c
docs: synced with upstream
connor-leech Sep 3, 2019
122c111
Merge branch 'master' into creation-flows
connor-leech Sep 3, 2019
0965611
docs: typo fixes
connor-leech Sep 3, 2019
ef948d6
Merge branch 'creation-flows' of https://github.com/connor-leech/carb…
connor-leech Sep 3, 2019
ecbab82
Merge branch 'master' into pattern-import
connor-leech Sep 4, 2019
6269d9e
Update index.mdx
connor-leech Sep 4, 2019
5ed632d
fix: shadow
alisonjoseph Sep 4, 2019
8d10e28
Merge branch 'master' into bug-fixes
alisonjoseph Sep 4, 2019
e690e05
docs: copy tweaks to Import pattern
connor-leech Sep 4, 2019
78511ce
docs: rearranged left nav
connor-leech Sep 4, 2019
ec3b506
Merge branch 'master' into bug-fixes
alisonjoseph Sep 4, 2019
1165beb
Link style spec typo
shixiedesign Sep 4, 2019
260db70
Merge branch 'master' into shixiedesign-patch-1
alisonjoseph Sep 5, 2019
d9e7a4c
fix: remove unnecessary entry title
vpicone Sep 5, 2019
8b77558
Update src/pages/experimental/import-pattern/index.mdx
connor-leech Sep 5, 2019
881d05e
Update src/pages/experimental/import-pattern/index.mdx
connor-leech Sep 5, 2019
85797a0
Update src/pages/experimental/import-pattern/index.mdx
connor-leech Sep 5, 2019
49ddac2
Update src/pages/experimental/import-pattern/index.mdx
connor-leech Sep 5, 2019
252d7ca
Update src/pages/experimental/import-pattern/index.mdx
connor-leech Sep 5, 2019
3068e63
Update src/pages/experimental/import-pattern/index.mdx
connor-leech Sep 5, 2019
6796a14
Update src/pages/experimental/import-pattern/index.mdx
connor-leech Sep 5, 2019
d814a52
chore: update packages 10.6
alisonjoseph Sep 5, 2019
69edd6f
Update index.mdx
connor-leech Sep 5, 2019
d911205
Merge branch 'master' into pattern-import
alisonjoseph Sep 5, 2019
6a92c89
Merge branch 'master' into bug-fixes
connor-leech Sep 5, 2019
2220a90
Merge pull request #230 from carbon-design-system/shixiedesign-patch-1
connor-leech Sep 5, 2019
ba62d18
Merge branch 'master' into bug-fixes
connor-leech Sep 5, 2019
ee5fd2d
Merge branch 'master' into 10.6
alisonjoseph Sep 5, 2019
0febc65
Merge branch 'master' into glossary-tweak
vpicone Sep 5, 2019
50438e1
Merge branch 'master' into pattern-import
alisonjoseph Sep 5, 2019
adf4886
Update src/data/nav-items.yaml
connor-leech Sep 5, 2019
b683909
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
22aefc3
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
00b03bd
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
39919bc
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
2a48778
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
fea08c4
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
433b23c
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
866a2e1
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
35de51f
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
953a723
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
03983ef
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
bb2de68
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
8f97839
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
88328af
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
146bc81
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
75fe48c
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
2979c13
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
9c5ee78
Merge pull request #199 from connor-leech/pattern-import
connor-leech Sep 5, 2019
a27d232
Merge branch 'master' into bug-fixes
connor-leech Sep 5, 2019
07e330d
Merge pull request #145 from alisonjoseph/bug-fixes
connor-leech Sep 5, 2019
45d1167
Merge branch 'master' into glossary-tweak
connor-leech Sep 5, 2019
127dc9d
Merge branch 'master' into creation-flows
connor-leech Sep 5, 2019
18a11ac
Merge pull request #252 from vpicone/glossary-tweak
connor-leech Sep 5, 2019
c7323d0
Merge branch 'master' into creation-flows
connor-leech Sep 5, 2019
3a3deea
Merge branch 'master' into 10.6
alisonjoseph Sep 5, 2019
838e9be
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
24683b9
Update src/pages/experimental/creation-flows/index.mdx
connor-leech Sep 5, 2019
a9534a2
docs: updated metadata
connor-leech Sep 5, 2019
7d95b98
docs: added pattern template
connor-leech Sep 5, 2019
1bf2c41
docs: less long and scary
connor-leech Sep 5, 2019
d486066
docs: added intro, changed terms to lowercase
tomwaterton Sep 6, 2019
d1f5973
Merge branch 'master' into glossary-edits-2
tomwaterton Sep 6, 2019
1b5c749
Merge pull request #121 from connor-leech/creation-flows
alisonjoseph Sep 6, 2019
f349274
Merge branch 'master' into glossary-edits-2
alisonjoseph Sep 6, 2019
b98a2b6
chore: attempt to get charts working
alisonjoseph Sep 6, 2019
570277c
Added in the page description component
tomwaterton Sep 6, 2019
8364dbe
Merge branch 'glossary-edits-2' of https://github.com/tomwaterton/car…
tomwaterton Sep 6, 2019
a653007
chore: add bar chart types
alisonjoseph Sep 6, 2019
cb82df9
chore: cleanup old file
alisonjoseph Sep 6, 2019
19a847a
Merge pull request #256 from tomwaterton/glossary-edits-2
janchild Sep 6, 2019
cab5631
Merge branch 'master' into 10.6
alisonjoseph Sep 6, 2019
e94d8a6
Merge branch 'master' into removing-pattern
connor-leech Sep 6, 2019
ca5b32e
docs: added link
connor-leech Sep 6, 2019
5159166
Update style.mdx
alisonjoseph Sep 6, 2019
266681a
Update index.mdx
alisonjoseph Sep 6, 2019
14855f7
Update index.mdx
alisonjoseph Sep 6, 2019
5869f0a
Merge branch 'master' into 10.6
alisonjoseph Sep 6, 2019
386d07e
Merge branch 'master' into removing-pattern
connor-leech Sep 6, 2019
08a3231
Merge pull request #253 from alisonjoseph/10.6
alisonjoseph Sep 6, 2019
303dd89
docs: copy tweaks
connor-leech Sep 6, 2019
35d94b6
docs: shortened sentences
connor-leech Sep 6, 2019
197d2fb
Merge branch 'master' into removing-pattern
connor-leech Sep 6, 2019
c05fee7
docs: page description
connor-leech Sep 6, 2019
280caee
Merge pull request #202 from connor-leech/removing-pattern
alisonjoseph Sep 6, 2019
48d7749
Merge branch 'master' into pattern-template
connor-leech Sep 6, 2019
aff1682
Merge pull request #255 from connor-leech/pattern-template
connor-leech Sep 6, 2019
69eea2b
docs: clean up
connor-leech Sep 6, 2019
500ae4a
Merge branch 'master' into generating-an-API-key
connor-leech Sep 6, 2019
640ce67
docs: renamed
connor-leech Sep 6, 2019
8be0f71
Update src/pages/experimental/generate-an-api-key/index.mdx
connor-leech Sep 6, 2019
10451d5
Update src/pages/experimental/generate-an-api-key/index.mdx
connor-leech Sep 6, 2019
67cf3dd
Update src/pages/experimental/generate-an-api-key/index.mdx
connor-leech Sep 6, 2019
48b3725
Update src/pages/experimental/generate-an-api-key/index.mdx
connor-leech Sep 6, 2019
c89c806
Update src/pages/experimental/generate-an-api-key/index.mdx
connor-leech Sep 6, 2019
aa579a4
docs: creation to create
connor-leech Sep 6, 2019
c02ddfc
Merge branch 'generating-an-API-key' of https://github.com/connor-lee…
connor-leech Sep 6, 2019
224888e
Merge pull request #205 from connor-leech/generating-an-API-key
connor-leech Sep 6, 2019
14975d3
docs: added October release article
connor-leech Sep 6, 2019
a866136
docs: updated table
connor-leech Sep 6, 2019
e55c9ac
docs: added links
connor-leech Sep 6, 2019
8335309
fix: add plex serif google font link
vpicone Sep 7, 2019
b761235
Merge pull request #267 from vpicone/serif-fix
alisonjoseph Sep 9, 2019
4c91dd9
Merge branch 'master' into oct-article
alisonjoseph Sep 9, 2019
b86e33a
Merge branch 'master' into whats-new-update
alisonjoseph Sep 9, 2019
0359b06
Update src/pages/index.mdx
connor-leech Sep 9, 2019
3ddde1b
Merge pull request #264 from connor-leech/oct-article
connor-leech Sep 9, 2019
3551248
Merge branch 'master' into whats-new-update
connor-leech Sep 9, 2019
b27940c
chore: upgrade carbon charts
alisonjoseph Sep 10, 2019
ceb9a94
Merge pull request #265 from connor-leech/whats-new-update
alisonjoseph Sep 10, 2019
0d7234b
Merge branch 'master' into charts
alisonjoseph Sep 10, 2019
7dbaff6
chore: add d3
alisonjoseph Sep 10, 2019
28dcd99
chore: update nav
alisonjoseph Sep 10, 2019
f08b634
fix: update color palette download link
alisonjoseph Sep 10, 2019
50b2846
Create test.txt
alisonjoseph Sep 10, 2019
b006056
Add files via upload
alisonjoseph Sep 10, 2019
5e02840
Delete test.txt
alisonjoseph Sep 10, 2019
b36f8a1
Merge pull request #281 from alisonjoseph/color-palette-download
alisonjoseph Sep 10, 2019
7f0a4d9
Merge branch 'master' of github.com:carbon-design-system/carbon-www i…
alisonjoseph Sep 11, 2019
7c07971
chore: test
alisonjoseph Sep 11, 2019
265d711
feat: import charts directly to mdx
alisonjoseph Sep 11, 2019
172d2d9
chore: add width and height
alisonjoseph Sep 11, 2019
d549525
chore: missing style import
alisonjoseph Sep 11, 2019
9f74f75
chore: simplify demo data files
alisonjoseph Sep 11, 2019
b9cfb41
chore: fix
alisonjoseph Sep 11, 2019
cbc0a2e
chore: update yarn lock
alisonjoseph Sep 11, 2019
5575cf3
chore: update data
alisonjoseph Sep 11, 2019
5ee6b5a
chore: move data file
alisonjoseph Sep 11, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions docs/pattern-template.mdx
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
---
title: Pattern title
---

<PageDescription>

Include a short description of your pattern. This header should be longer than one line and no longer than four.

</PageDescription>

<AnchorLinks>
<AnchorLink>Overview</AnchorLink>
<AnchorLink>Behavior guidance</AnchorLink>
<AnchorLink>Assets</AnchorLink>
<AnchorLink>References</AnchorLink>
<AnchorLink>Metadata</AnchorLink>
</AnchorLinks>

### Overview

**Define the use of your pattern with a problem statement.** Explain a user's needs and how the pattern meets those needs. Communicate anything a designer needs to know about the pattern.

**Show a high-level image of the pattern in use.** The pattern should be presented in context and include a caption.

### Behavior guidance

**Include guidance on interactions and states.** Most patterns depend on interactions with components. Include guidance on motion, behavior, and states of the components.

**Use visuals wherever possible.** Show a user's flow through your pattern with images of your product at each step of the way.

### Assets

**Include any resources and references.** Attach and document any page templates, design specifications, and design software assets.

**Document how a user would navigate your pattern.** Provide documentation to make onboarding and use easier.

**Create a functional prototype.** The best way to prove your pattern solves a problem is to let designers test it. A link to the actual implementation is best, and a demo is also valuable.

### References

**Explain any accessibility testing you conducted.** No individual component or pattern can be accessible, but they can be used in an accessible way to create an accessible experience. Include any research and proof you may have in your pattern documentation.

**Include any citations.** Research, books, and articles you found helpful offer legitimacy to your pattern and help designers understand your decisions.

**Offer any development notes you may have.** Many patterns don't require specific developer attention to implement. If you have any developer guidance, include it here.

### Metadata 

**Include a list of components used in the pattern.** Link to where where each component is documented.

**Link to any related patterns.** This may not be the right pattern for a designer's problem, but other closely related patterns might be helpful.

**Link to the maintainer's GitHub profile.** GitHub is the best way to ask questions and provide feedback about the pattern.

**Communicate what happens next.** If there are any outstanding issues or gaps, include those here. Ask for help if you need it, and be transparent about the completeness of the pattern.
10 changes: 9 additions & 1 deletion gatsby-ssr.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
/* eslint-disable import/prefer-default-export */
import React from 'react';

export const onRenderBody = ({ setPostBodyComponents }) =>
export const onRenderBody = ({ setPostBodyComponents, setHeadComponents }) => {
setHeadComponents([
<link
key="serif"
href="https://fonts.googleapis.com/css?family=IBM+Plex+Serif&display=swap"
rel="stylesheet"
/>,
]);
setPostBodyComponents([
<script
key="docsearch"
src="https://cdn.jsdelivr.net/npm/docsearch.js@2.6.2/dist/cdn/docsearch.min.js"
/>,
]);
};
15 changes: 8 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,17 @@
"timestamp": "./build-timestamp.sh"
},
"dependencies": {
"@carbon/charts": "^0.15.8",
"@carbon/charts-react": "^0.15.7",
"@carbon/elements": "^10.5.1",
"@carbon/icons": "^10.5.0",
"@carbon/icons-react": "^10.5.0",
"@carbon/charts": "^0.16.2",
"@carbon/charts-react": "^0.16.2",
"@carbon/elements": "^10.6.0",
"@carbon/icons": "^10.6.0",
"@carbon/icons-react": "^10.6.0",
"babel-eslint": "^10.0.3",
"carbon-components": "^10.5.1",
"carbon-components-react": "^7.5.1",
"carbon-components": "^10.6.0",
"carbon-components-react": "^7.6.0",
"change-case": "^3.1.0",
"classnames": "^2.2.6",
"d3": "^5.12.0",
"docsearch.js": "^2.6.3",
"gatsby": "^2.13.73",
"gatsby-plugin-compile-es6-packages": "^2.1.0",
Expand Down
74 changes: 0 additions & 74 deletions src/components/Charts/StackedBar.js

This file was deleted.

5 changes: 2 additions & 3 deletions src/components/GlossaryComponent/GlossaryList/GlossaryList.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class Glossary extends Component {
{glossaryEntry}
<span>{glossaryEntry}</span>
</h2>
{Object.keys(entry).map(list => {
{Object.keys(entry).map((list, i) => {
const listItems = Object.keys(entry[list]).map(word => {
counter += 1;
const currentWord = entry[list][word];
Expand Down Expand Up @@ -50,8 +50,7 @@ class Glossary extends Component {
);
});
return (
<div key={list} className="glossary-entry__list">
<h3 className="glossary-entry__heading page-h3">{list}</h3>
<div key={i} className="glossary-entry__list">
{listItems}
</div>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
padding-top: rem(36px);
}

.glossary-entry__main-heading {
margin-bottom: $spacing-06;
}

.glossary-entry__main-heading span {
text-transform: lowercase;
}
Expand Down
5 changes: 3 additions & 2 deletions src/components/TypesetStyle/TypesetStyle.js
Original file line number Diff line number Diff line change
Expand Up @@ -871,11 +871,12 @@ class TypesetStyle extends React.Component {
addScrollListener() {
document.addEventListener('scroll', () => {
if (this.refs.stickyBar) {
if (this.refs.stickyBar.getBoundingClientRect().top <= 104) {
console.log(this.refs.stickyBar.getBoundingClientRect().top);
if (this.refs.stickyBar.getBoundingClientRect().top <= 112) {
this.setState({
sticky: true,
});
} else if (this.refs.stickyBar.getBoundingClientRect().top > 104) {
} else if (this.refs.stickyBar.getBoundingClientRect().top > 112) {
this.setState({
sticky: false,
});
Expand Down
14 changes: 11 additions & 3 deletions src/components/TypesetStyle/typeset-example.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@

.bx--typeset-example {
margin-top: $spacing-05;
margin-left: -$spacing-03;
margin-right: -$spacing-03;

@include carbon--breakpoint('md') {
margin-left: 0;
margin-right: 0;
}
}

.bx--typeset-example-row {
Expand All @@ -17,11 +24,12 @@
}

.bx--typeset-example-description {
padding: $spacing-05 15% $spacing-05 $spacing-05;
padding: $spacing-05;
overflow: hidden;

@include carbon--breakpoint('md') {
width: 62.5%;
padding-right: 15%;
}

@include carbon--breakpoint('lg') {
Expand All @@ -30,10 +38,10 @@
}

.bx--typeset-example-specs {
padding: $spacing-05;
width: 33.3%;
padding: $spacing-05 $spacing-06;

@include carbon--breakpoint('md') {
width: 33.3%;
border-left: 1px solid $carbon--gray-20;
}
}
Expand Down
61 changes: 9 additions & 52 deletions src/components/TypesetStyle/typeset-style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ $prefix: 'bx';
align-items: center;
height: 3rem;
border-top: 1px solid $carbon--gray-20;
border-bottom: 1px solid $carbon--gray-20;
padding-left: $spacing-05;
padding-right: $spacing-05;
display: grid;
Expand All @@ -149,6 +150,7 @@ $prefix: 'bx';

@include carbon--breakpoint('md') {
border-top: none;
border-bottom: none;
border-left: 1px solid $carbon--gray-20;
width: 37.5%;
}
Expand Down Expand Up @@ -369,6 +371,13 @@ $prefix: 'bx';
transition-property: top;
transition-duration: $transition--expansion;
transition-timing-function: $carbon--standard-easing;
margin-left: -$spacing-03;
margin-right: -$spacing-03;

@include carbon--breakpoint('md') {
margin-left: 0;
margin-right: 0;
}
}

div[class*='PageHeader-module--page-header--shifted']
Expand Down Expand Up @@ -407,55 +416,3 @@ div[class*='PageHeader-module--page-header--shifted']
top: 8.5rem;
}
}

// ------------------------------------------------------
// Typeset Example
// ------------------------------------------------------
.#{$prefix}--typeset-example-container {
margin-top: $spacing-05;
}

.#{$prefix}--typeset-example {
margin-top: $spacing-05;
}

.#{$prefix}--typeset-example-row {
background-color: $carbon--white-0;
min-height: rem(216px);
}

.#{$prefix}--typeset-example-group-title {
background-color: $carbon--gray-20;
height: 4rem;
}

.#{$prefix}--typeset-example-description {
padding: $spacing-05 15% $spacing-05 $spacing-05;
overflow: hidden;

@include carbon--breakpoint('md') {
width: 62.5%;
}

@include carbon--breakpoint('lg') {
width: 66.7%;
}
}

.#{$prefix}--typeset-example-specs {
padding: $spacing-05;
width: 33.3%;

@include carbon--breakpoint('md') {
border-left: 1px solid $carbon--gray-20;
}
}

.#{$prefix}--typeset-example-specs-text {
margin-bottom: $spacing-03;
}

.#{$prefix}--typeset-example-code-style {
display: block;
margin-top: $spacing-03;
}
Loading