Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added intro, changed terms to lowercase #256

Merged
merged 5 commits into from
Sep 6, 2019
Merged

docs: added intro, changed terms to lowercase #256

merged 5 commits into from
Sep 6, 2019

Conversation

tomwaterton
Copy link
Contributor

Relates to #245

Changelog

New

  • I've added a brief intro statement at the top of the Glossary page.

Changed

  • I've changed all terms to be listed in lowercase
  • I enhanced the guidance for the term "OK"

Removed

  • I removed the "Idioms" section that was still appearing under the letter "T"

This commit also adds back "babel-eslint" into the package.json file (which seems to have been missing for some unknown reason.)

@vercel
Copy link

vercel bot commented Sep 6, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://carbon-website-git-fork-tomwaterton-glossary-edits-2.carbon-design-system.now.sh

@vercel vercel bot temporarily deployed to staging September 6, 2019 06:30 Inactive
@alisonjoseph alisonjoseph requested a review from a team September 6, 2019 12:08
@ghost ghost requested review from janchild and removed request for a team September 6, 2019 12:08
alisonjoseph
alisonjoseph requested changes Sep 6, 2019
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than adding the page description component!

alisonjoseph
alisonjoseph approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

janchild
janchild approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks so much, @tomwaterton

@janchild janchild merged commit 19a847a into carbon-design-system:master Sep 6, 2019
@tomwaterton tomwaterton deleted the glossary-edits-2 branch September 6, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@janchild janchild janchild approved these changes

Assignees
No one assigned
Labels
status: content review ✍️ status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomwaterton @alisonjoseph @janchild