Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(number input): update images and documentation #2286

Merged
merged 6 commits into from
May 6, 2021

Conversation

johnbister
Copy link
Contributor

@johnbister johnbister commented May 5, 2021

Closes #2274

The guidelines do not reflect the current Number Input component.

Changelog

Updated usage and style images to current component design
-number-input-usage-1.png
-number-input-style-1.png
-number-input-style-2.png

Edited style->structure text to reflect redesign

Please checkout:

Components/NumberInput/Usage
Components/NumberInput/Style

@vercel
Copy link

vercel bot commented May 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/AXhkyoSuSkvJGqU8W9H1RXEUD9vD
✅ Preview: https://carbondesignsy-git-fork-johnbister-number-input-carbon-d-1188cb.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

DCO Assistant Lite bot All contributors have signed the DCO.

@johnbister
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@johnbister johnbister marked this pull request as ready for review May 5, 2021 21:04
@johnbister johnbister requested a review from a team May 5, 2021 21:04
@johnbister johnbister requested a review from a team as a code owner May 5, 2021 21:04
@johnbister johnbister changed the title [DRAFT] fix(number input): update images and documentation fix(number input): update images and documentation May 5, 2021
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit e39ffcd into carbon-design-system:main May 6, 2021
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
…tem#2286)

* fix:  number input usage 1 image

* fix: number input style 2 image

* fix: number input style 1 image

* fix: edit style structure description

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
…tem#2286)

* fix:  number input usage 1 image

* fix: number input style 2 image

* fix: number input style 1 image

* fix: edit style structure description

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number Input Documentation Conflict
4 participants