Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rule color for dropdown gifs #2021

Merged
merged 6 commits into from
Dec 10, 2020
Merged

Fix rule color for dropdown gifs #2021

merged 6 commits into from
Dec 10, 2020

Conversation

johnbister
Copy link
Contributor

@johnbister johnbister commented Dec 1, 2020 •
edited
Loading

Changed

  • fixed select-usage-1.gif and dropdown-usage-14.gif with correct color (ui-03) for rule dividing field and menu when open

For review, checkout:

components>dropdown>invalid
components>select>validation

@vercel
Copy link

vercel bot commented Dec 1, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/bz8ejxjh6
✅ Preview: https://carbondesignsystem-git-dropdown-gifs.carbon-design-system.vercel.app

@johnbister johnbister changed the title Fix the ruler color for dropdown gifs Fix ruler color for dropdown gifs Dec 1, 2020
@johnbister johnbister changed the title Fix ruler color for dropdown gifs Fix rule color for dropdown gifs Dec 2, 2020
@johnbister johnbister marked this pull request as ready for review December 2, 2020 16:13
@johnbister johnbister requested a review from a team as a code owner December 2, 2020 16:13
laurenmrice
laurenmrice approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! 🙌🏻

andreancardona
andreancardona approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! @johnbister looks good. :)

@tw15egan
Copy link
Collaborator

tw15egan commented Dec 3, 2020

Should we be showing a Select that looks like it has custom styling? Since our select is just a native HTML <select> element, the menu isn't styled by us but rendered by the browser:

Screen Shot 2020-12-03 at 11 32 05 AM

@kodiakhq kodiakhq bot merged commit c7be8e7 into carbon-design-system:master Dec 10, 2020
@johnbister johnbister deleted the dropdown-gifs branch May 5, 2021 16:06
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@johnbister @kodiakhq @natashadecoste
fix: correct ruler color for dropdown gifs (carbon-design-system#2021)
1090f09 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@johnbister @kodiakhq @natashadecoste
fix: correct ruler color for dropdown gifs (carbon-design-system#2021)
33e0da2 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@andreancardona andreancardona andreancardona approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnbister @tw15egan @andreancardona @laurenmrice