Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pattern): removing pattern #202

Merged
merged 6 commits into from
Sep 6, 2019
Merged

docs(pattern): removing pattern #202

merged 6 commits into from
Sep 6, 2019

Conversation

connor-leech
Copy link
Contributor

This pattern was a contribution. Original PR here:

carbon-design-system/carbon-website-archive#1699

@vercel
Copy link

vercel bot commented Aug 28, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://carbon-website-git-fork-connor-leech-removing-pattern.carbon-design-system.now.sh

@connor-leech connor-leech changed the title docs: migrated removing pattern docs(pattern): removing pattern Aug 28, 2019
@vpicone
Copy link
Contributor

vpicone commented Aug 29, 2019

Same for this one, and maybe the others? If it was closed over there shouldn't it be closed here too?

@vercel vercel bot temporarily deployed to staging September 6, 2019 18:06 Inactive
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@alisonjoseph alisonjoseph merged commit 280caee into carbon-design-system:master Sep 6, 2019
@connor-leech connor-leech deleted the removing-pattern branch September 6, 2019 18:45
@alisonjoseph
Copy link
Member

@vpicone I believe they were originally closed because design didn't have time to review in-depth, so the plan instead now is to just get them in under experimental so there is something there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants