-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(pattern): import pattern #199
docs(pattern): import pattern #199
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://carbon-website-git-fork-connor-leech-pattern-import.carbon-design-system.now.sh |
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work, @connor-leech !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me, with the caveat that the drag n drop uploader is still a component PR waiting to be approved/merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One small comment is we should limit updating page titles/urls, this changes the link and we're running into issues because of this. We are planning on setting up redirects, so once that is in place any future nav changes will also need the redirect included.
This pattern was a contribution. Original PR here:
carbon-design-system/carbon-website-archive#1711