Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pattern): import pattern #199

Merged
merged 15 commits into from
Sep 5, 2019
Merged

docs(pattern): import pattern #199

merged 15 commits into from
Sep 5, 2019

Conversation

connor-leech
Copy link
Contributor

This pattern was a contribution. Original PR here:

carbon-design-system/carbon-website-archive#1711

@vercel
Copy link

vercel bot commented Aug 28, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://carbon-website-git-fork-connor-leech-pattern-import.carbon-design-system.now.sh

@connor-leech connor-leech changed the title docs: import modal docs(pattern): import pattern Aug 28, 2019
connor-leech and others added 4 commits September 5, 2019 12:25
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to staging September 5, 2019 17:26 Inactive
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to staging September 5, 2019 17:32 Inactive
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to staging September 5, 2019 17:38 Inactive
@vercel vercel bot temporarily deployed to staging September 5, 2019 18:16 Inactive
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work, @connor-leech !

Copy link
Contributor

@chrisconnors-ibm chrisconnors-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, with the caveat that the drag n drop uploader is still a component PR waiting to be approved/merged

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One small comment is we should limit updating page titles/urls, this changes the link and we're running into issues because of this. We are planning on setting up redirects, so once that is in place any future nav changes will also need the redirect included.

@connor-leech connor-leech merged commit 9c5ee78 into carbon-design-system:master Sep 5, 2019
@connor-leech connor-leech deleted the pattern-import branch September 5, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants