Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple visual bug fixes #145

Merged
merged 11 commits into from
Sep 5, 2019
Merged

fix: multiple visual bug fixes #145

merged 11 commits into from
Sep 5, 2019

Conversation

alisonjoseph
Copy link
Member

@vercel
Copy link

vercel bot commented Aug 23, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://carbon-website-git-fork-alisonjoseph-bug-fixes.carbon-design-system.now.sh

@alisonjoseph alisonjoseph changed the title fix: multiple bug fixes fix: multiple visual bug fixes Aug 23, 2019
@alisonjoseph alisonjoseph mentioned this pull request Aug 26, 2019
Closed
@alisonjoseph alisonjoseph requested a review from a team August 28, 2019 15:59
@alisonjoseph alisonjoseph requested review from a team and removed request for a team and jeanservaas September 3, 2019 21:14
@ghost ghost requested review from designertyler and removed request for a team September 3, 2019 21:14
aagonzales
aagonzales reviewed Sep 4, 2019
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ #141 I'm not seeing the drop-shadow in the deploy link
image
✅ #140
✅ #138
✅ #137

@vercel vercel bot temporarily deployed to staging September 4, 2019 18:13 Inactive
@alisonjoseph
Copy link
Member Author

Oh good catch @aagonzales should be fixed now hopefully 🙏

aagonzales
aagonzales approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing. #shipit

@alisonjoseph alisonjoseph removed the request for review from designertyler September 4, 2019 19:56
@vercel vercel bot temporarily deployed to staging September 5, 2019 18:36 Inactive
@connor-leech connor-leech merged commit 07e330d into carbon-design-system:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpicone vpicone vpicone approved these changes

@aagonzales aagonzales aagonzales approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
4 participants
@alisonjoseph @vpicone @aagonzales @connor-leech