-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(pattern): creation flows #121
docs(pattern): creation flows #121
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://carbon-website-git-fork-connor-leech-creation-flows.carbon-design-system.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typos:
Standard creation
- Button position: The label should be Button position not Buttion position. This image caption seems like a copy of Advanced options and should reflect the image.
- Full page: The image captions for 'Full page' should say full not fill.
- Advanced option: The label 'Advanced option' should not have a capital O? Under the label 'Advanced option' - second paragraph, it should be choose not chose. There is also duplicate content in these paragraphs.
- Have periods after all image captions. Some are currently missing.
Multistep creation:
- The image caption for 'Illustration/Image' should be reflecting the image. This image caption seems like a copy of Advanced options.
- Side panel - second image caption: Maybe this caption should be the same as the first image caption, since its not the start of the creation flow.
Images:
didnt realize you didnt want a review and just are trying to merge over ! :P will approve |
@laurenmrice thanks for the thorough feedback! I haven't actually done a copy pass on this yet. I believe @jeanservaas is going to clean up these images. I'll re-request your review once the copy has been reworked. |
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Migrated the Creation flows pattern to the new site repo.
carbon-design-system/carbon-website-archive#1655