Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pattern): creation flows #121

Merged
merged 38 commits into from
Sep 6, 2019
Merged

docs(pattern): creation flows #121

merged 38 commits into from
Sep 6, 2019

Conversation

connor-leech
Copy link
Contributor

Migrated the Creation flows pattern to the new site repo.

carbon-design-system/carbon-website-archive#1655

@vercel
Copy link

vercel bot commented Aug 21, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://carbon-website-git-fork-connor-leech-creation-flows.carbon-design-system.now.sh

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos:
Standard creation

  • Button position: The label should be Button position not Buttion position. This image caption seems like a copy of Advanced options and should reflect the image.
  • Full page: The image captions for 'Full page' should say full not fill.
  • Advanced option: The label 'Advanced option' should not have a capital O? Under the label 'Advanced option' - second paragraph, it should be choose not chose. There is also duplicate content in these paragraphs.
  • Have periods after all image captions. Some are currently missing.

Multistep creation:

  • The image caption for 'Illustration/Image' should be reflecting the image. This image caption seems like a copy of Advanced options.
  • Side panel - second image caption: Maybe this caption should be the same as the first image caption, since its not the start of the creation flow.

Images:

  • I think the lead image should not be cropped and should show the full browser inside the white container (like the Navigation pattern page).
  • For images that have a white background inside the white container, add a 1px border around the image that is Gray 20 (#dcdcdc)
    Ex:
    Artboard

@laurenmrice
Copy link
Member

didnt realize you didnt want a review and just are trying to merge over ! :P will approve

@connor-leech
Copy link
Contributor Author

@laurenmrice thanks for the thorough feedback! I haven't actually done a copy pass on this yet. I believe @jeanservaas is going to clean up these images. I'll re-request your review once the copy has been reworked.

@connor-leech connor-leech changed the title docs: creation flows docs(pattern): creation flows Aug 28, 2019
@vercel vercel bot temporarily deployed to staging August 29, 2019 14:29 Inactive
connor-leech and others added 2 commits September 5, 2019 14:12
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to staging September 5, 2019 19:13 Inactive
connor-leech and others added 2 commits September 5, 2019 14:13
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to staging September 5, 2019 19:14 Inactive
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to staging September 5, 2019 19:14 Inactive
connor-leech and others added 3 commits September 5, 2019 14:14
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to staging September 5, 2019 20:27 Inactive
Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com>
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alisonjoseph alisonjoseph merged commit 1b5c749 into carbon-design-system:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants