Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slug): tile updates #11464

Closed
wants to merge 7 commits into from
Closed

feat(slug): tile updates #11464

wants to merge 7 commits into from

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

Follows: carbon-design-system/carbon#15596 & carbon-design-system/carbon#15591

Description

Updates Tile with carbon gradient

Changelog

Changed

  • new carbon upgrade (using RC atm -> will need to update to full release)
  • updated tile slug styles like core
  • the new core styles fix an error with number-input slug revert styles

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner January 29, 2024 22:22
@ariellalgilmore ariellalgilmore requested review from annawen1 and sangeethababu9223 and removed request for a team January 29, 2024 22:22
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 29, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11464/index.html

Built with commit: de1024c43db662e68ed9276ccb9428b3308024b2

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 29, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11464/index.html

Built with commit: de1024c43db662e68ed9276ccb9428b3308024b2

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 29, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11464/index.html

Built with commit: de1024c43db662e68ed9276ccb9428b3308024b2

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 29, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11464/index.html

Built with commit: de1024c43db662e68ed9276ccb9428b3308024b2

@ariellalgilmore ariellalgilmore added package: carbon web components area: AI Used to filter issues in the Carbon for AI project. labels Jan 30, 2024
kennylam
kennylam approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, but will probably need a proper visual review.

aagonzales
aagonzales approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me too!

@kennylam kennylam added Ready to merge Label for the pull requests that are ready to merge and removed DO NOT MERGE labels Feb 1, 2024
@ariellalgilmore ariellalgilmore added DO NOT MERGE and removed Ready to merge Label for the pull requests that are ready to merge labels Feb 1, 2024
@ariellalgilmore
Copy link
Member Author

closing in favor for #11484

@ariellalgilmore ariellalgilmore deleted the feat/slug-tile-updates branch February 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@kennylam kennylam kennylam approved these changes

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
area: AI Used to filter issues in the Carbon for AI project. DO NOT MERGE package: carbon web components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ariellalgilmore @ibmdotcom-bot @kennylam @aagonzales