fix(data-table): move ToolbarSearch filtering to DataTable for Svelte 5 compatibility
#2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToolbarSearch filtering in DataTableToolbarSearch filtering to DataTable for Svelte 5 compatibility
|
Released in v0.86.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2033
Svelte 5 exposes a bug when using
DataTableandToolbarSearch. Initial filtering might work, but original rows are not reset.The root cause is a reset loop caused by
ToolbarSearch. It currently reads and writes$tableRows, which is the source of truth used byDataTable.One of the constraints is for
filteredIdsto be bindable toToolbarSearch(but not two-way reactivity). Beyond that,ToolbarSearchshould not need to read the sourcerowsor manipulate them directly.The solution is to move the filtering logic to the parent
DataTable. A copy of the original rows is set (unlessrowschanges). Filtering will then filter on a subset of the copy without modifying the source.