fix(zoombar): use Tools.isEmpty instead of lodash.isEmpty import

[moczolaszlo]

Hi, our Webpack build throws an error with the latest version(s) of charts/react-charts packages:

ERROR in ./node_modules/@carbon/charts/components/axes/zoom-bar.js
 Module not found: Error: Can't resolve 'lodash/isEmpty' in '/node_modules/@carbon/charts/components/axes'

Updates

I changed the lodash.isEmpty import to the lodash-es version and refactored the code to use it from the Tools namespace, like Tools.isEmpty.
This could fix our build, too. 😄

Review checklist (for reviewers only)

• Demos all features
• Documented/annotated
• Matches UI/UX specs
• Meets the code style guide
• Accessible
• Mobile first (responsive)
• RTL support (bidirectional text)
• Performant (limited bloat)

[theiliad]

Hi, our Webpack build throws an error with the latest version(s) of charts/react-charts packages:

ERROR in ./node_modules/@carbon/charts/components/axes/zoom-bar.js
 Module not found: Error: Can't resolve 'lodash/isEmpty' in '/node_modules/@carbon/charts/components/axes'

Updates

I changed the lodash.isEmpty import to the lodash-es version and refactored the code to use it from the Tools namespace, like Tools.isEmpty.
This could fix our build, too. 😄

Review checklist (for reviewers only)

• Demos all features
• Documented/annotated
• Matches UI/UX specs
• Meets the code style guide
• Accessible
• Mobile first (responsive)
• RTL support (bidirectional text)
• Performant (limited bloat)

Hi, yes I've caught this error as well. Seems to have come into the codebase with a PR that we merged. I'll fix that

[moczolaszlo]

Hi, yes I've caught this error as well. Seems to have come into the codebase with a PR that we merged. I'll fix that

Yes, this was that PR: #855

[theiliad]

Hi, yes I've caught this error as well. Seems to have come into the codebase with a PR that we merged. I'll fix that

Yes, this was that PR: #855

Yes, we use lodash-es however the PR added an import to lodash. PR coming

[moczolaszlo]

I'm not really understand what was the problem with this PR, because you made the same - that is more work (make a workbranch, PR, etc) 😄 . But the most important is the fix is released, thank you!