Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): should use valueFormatter for single values #779

Merged
merged 1 commit into from
Sep 1, 2020
Merged

fix(tooltip): should use valueFormatter for single values #779

merged 1 commit into from
Sep 1, 2020

Conversation

scottdickerson
Copy link
Contributor

@scottdickerson scottdickerson commented Aug 31, 2020 •
edited
Loading

Updates

Instead of hardcoding the formatting for single values, rely on the this.valueFormatter method. Fixes this issue:
#778

Demo screenshot or recording

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@scottdickerson scottdickerson requested review from sophiiae and removed request for a team August 31, 2020 16:52
@theiliad theiliad merged commit 8883672 into carbon-design-system:master Sep 1, 2020
@theiliad theiliad added the type: bug 🐛 Something isn't working label Sep 1, 2020
sambacha pushed a commit to freight-trust/carbon-charts that referenced this pull request Sep 26, 2020
@hlyang397 @carbon-bot
@theiliad @metonym @natashadecoste @JennChao @scottdickerson
Sparkline for demo (#17)
45e7907 
* fix: fix tooltip position with zoom bar enabled (carbon-design-system#732)

* fix: fix tooltip position with zoom bar enabled

* fix: change variable name to make it clear

* Merge pull request carbon-design-system#737 from hlyang397/fix-join-problem

* v0.34.9

* Merge pull request carbon-design-system#739 from theiliad/add-zoombar-slider

* add separate slider view height values

* feat(core, angular, vue, svelte, react): add slider view to zoombar

* refactor

* format

* v0.34.10

* Merge pull request carbon-design-system#728 from sophiiae/legend-order

* feat: add legend order option

* refactor: sort legend only

* fix: fix legend order default value

* fix: solve partial defined ordering case

* refactor: put legend ordering in separate function

* fix: fix demo

* fix: fix demo

Co-authored-by: Fei <fei-fei.zheng@ibm.com>

* v0.34.11

* Update README.md

* feat(svelte): add Meter chart wrapper (carbon-design-system#744)

* Merge pull request carbon-design-system#745 from hlyang397/support_mobile_event

* v0.35.0

* Add files via upload

* chore(monorepo): update logo (carbon-design-system#746)

* Add files via upload

* Update README.md

* Merge pull request carbon-design-system#749 from theiliad/seperate-non-customizables

* fix(core): separate out non-customizables in configuration.ts

* format

* v0.35.1

* Merge pull request carbon-design-system#756 from sophiiae/pie-donut-skeleton

* fix(core, angular, vue, react, svelt): fix missing donut / pie skeleton

* fix(core, angular, vue, react, svelt): fix pie/donut skeleton alignment

* style(core, angular, vue, react, svelt): remove redundant variable

Co-authored-by: Fei <fei-fei.zheng@ibm.com>

* v0.35.2

* Merge pull request carbon-design-system#757 from natashadecoste/react-events-fix

* chore(angular): add angular 9 dependency versions to peerDependencies

* fix(react): compare props before updating component to avoid re-render of same chart

* compare props with new props for all charts

Co-authored-by: Eliad Moosavi <iliadmoosavi@gmail.com>

* v0.35.3

* feat: enable chart grid enable option

* refactor: rename grid option

* feat: change zoom bar handle cursor to ew-resize (carbon-design-system#759)

* feat: change zoom bar handle cursor to ew-resize

* Update zoom-bar.ts

Co-authored-by: Eliad Moosavi <theiliad@users.noreply.github.com>

* Merge pull request carbon-design-system#760 from hlyang397/avoid-duplicate-spacer

* v0.36.0

* refactor: rename gridEnabled to isGridEnabled

* fix: enable grid as default setting

* feat: enable or disable x and y grid separately

* feat: enable or disable ruler

* feat: enable or disable tooltip

* fix: enable tooltip as default setting

* fix: enable ruler as default setting

* fix: not positioning tooltip when tooltip is disabled

* feat: enable or disable scatter dot on charts except scatter chart

* refactor: only go through init and render when isTooltipEnabled is true

* refactor: move isRulerEnabled into render

* refactor: remove backdrop event listener

* refactor: rename variable

* feat: gradient util

* feat: refactor and add sparkline storybook in area chart section

* refactor: eslint error

* fix: set default gradientEnabled to false

* refactor: remove class variable isTooltipEnabled

* refactor: interface modification for xGridEnabled and yGridEnabled

* feat: hide or show axis

* Merge pull request carbon-design-system#779 from scottdickerson/fix-tooltip-valueformatter

* v0.36.1

* Merge pull request carbon-design-system#764 from hlyang397/fix-scatter-stacked-tooltip

* fix: stacked scatter tooltip not show

- abstract getTooltipData function to allow override
- implement getTooltipData function in scatter-stacked with stacked data

* refactor: change variable name from data to datum

* refactor: updatable tooltip event listener

* refactor: rename grid option

* v0.36.2

* fix: allow apply gradient style when there is only one dataset

* refactor: only render needed code when axis is disabled

* refactor: flag for checking whether tooltip event listener is added or not

* feat: sparkline loading state

* feat: sparkline loading storybook

* refactor: rename class

* refactor: remove code for styling backdrop in ruler component

* Merge branch 'sparkline-loading' of https://github.com/JennChao/carbon-charts into sparkline-for-demo

* fix: only apply custom options to sparkline chart

Co-authored-by: Eric Yang <59426533+hlyang397@users.noreply.github.com>
Co-authored-by: carbon-bot <carbon@us.ibm.com>
Co-authored-by: Eliad Moosavi <theiliad@users.noreply.github.com>
Co-authored-by: Fei Z <feifeizheng@outlook.com>
Co-authored-by: Fei <fei-fei.zheng@ibm.com>
Co-authored-by: Eric Liu <ericyl.us@gmail.com>
Co-authored-by: natashadecoste <natasha.decoste@gmail.com>
Co-authored-by: Eliad Moosavi <iliadmoosavi@gmail.com>
Co-authored-by: Jennifer Chao <jennchao91@gmail.com>
Co-authored-by: Scott Dickerson <6663002+scottdickerson@users.noreply.github.com>
theiliad pushed a commit to theiliad/carbon-charts that referenced this pull request May 17, 2021
@scottdickerson
Merge pull request carbon-design-system#779 from scottdickerson/fix-t…
83695e4 
…ooltip-valueformatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natashadecoste natashadecoste natashadecoste approved these changes

@theiliad theiliad theiliad approved these changes

@sophiiae sophiiae Awaiting requested review from sophiiae

Assignees
No one assigned
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottdickerson @natashadecoste @theiliad