Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5 runes mode #1959

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nstuyvesant
Copy link
Contributor

Updates

  • @carbon/charts-svelte distribution tag is set to next to prevent breaking changes from affecting current users
  • Bumped dependencies: svelte, vite, lerna
  • Updated README examples to use Svelte 5 patterns
  • Adjusted peerDependency for Svelte 5.20+
  • Improved typing for components
  • Added JSDoc comments for properties
  • Changed event emission to Svelte 5 pattern of passing callback functions
  • Ran prettier on updated files

Breaking changes (only for those who choose to use next distribution tag)

  1. Svelte must be 5.20 or later
  2. Event handlers on:load, on:update and on:destroy become callback functions passed as properties onload, onupdate and ondestroy. Other than removing the colon (as you must with other event handlers like on:click), no changes should be needed.

@nstuyvesant nstuyvesant requested review from theiliad and a team as code owners February 19, 2025 18:43
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 06adad7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/67b72f21ed9a0500087f048d
😎 Deploy Preview https://deploy-preview-1959--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 06adad7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/67b72f2125e9520008bfd227
😎 Deploy Preview https://deploy-preview-1959--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for carbon-charts-docs ready!

Name Link
🔨 Latest commit 06adad7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-docs/deploys/67b72f21c15ac300082f6b84
😎 Deploy Preview https://deploy-preview-1959--carbon-charts-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 06adad7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/67b72f21ace88900080a9e56
😎 Deploy Preview https://deploy-preview-1959--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant