Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(svelte): add TypeScript definitions for BoxplotChart, WordCloudChart #1003

Merged
merged 2 commits into from
Apr 27, 2021
Merged

feat(svelte): add TypeScript definitions for BoxplotChart, WordCloudChart #1003

merged 2 commits into from
Apr 27, 2021

Conversation

metonym
Copy link
Contributor

@metonym metonym commented Apr 23, 2021 •
edited
Loading

Closes #963

Updates

  • add TypeScript definitions for BoxplotChart.svelte, WordCloudChart.svelte
  • add corresponding tests to the tests folder

To test this, run yarn test in packages/svelte. The svelte-check library should not report any errors.

Demo screenshot or recording

N/A

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@metonym metonym requested review from natashadecoste, theiliad and a team as code owners April 23, 2021 20:02
@metonym metonym requested review from zvonimirfras and removed request for a team April 23, 2021 20:02
theiliad
theiliad approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉 thank you @metonym not sure why I missed these

@theiliad theiliad requested a review from sophiiae April 26, 2021 20:26
@theiliad theiliad merged commit 83efddd into carbon-design-system:master Apr 27, 2021
theiliad pushed a commit to theiliad/carbon-charts that referenced this pull request May 17, 2021
@metonym @natashadecoste
release - feat(svelte): add TypeScript definitions for BoxplotChart, …
a0f4d19 
…WordCloudChart carbon-design-system#963 (carbon-design-system#1003)

Closes carbon-design-system#963

Co-authored-by: natashadecoste <natasha.decoste@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natashadecoste natashadecoste natashadecoste approved these changes

@theiliad theiliad theiliad approved these changes

@sophiiae sophiiae sophiiae approved these changes

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding typing & tests for the new boxplot component in svelte wrappers
4 participants
@metonym @natashadecoste @theiliad @sophiiae