Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing dependency #189

Closed
cdaringe opened this issue Jan 3, 2021 · 2 comments
Closed

missing dependency #189

cdaringe opened this issue Jan 3, 2021 · 2 comments
Assignees

Comments

@cdaringe
Copy link

cdaringe commented Jan 3, 2021

problem

i installed happy-dom into my app, and at import of happy-dom:

Error: Cannot find module 'whatwg-encoding'
Require stack:
- /Users/cdaringe/src/factorio-ts/packages/json-schema-producer/node_modules/happy-dom/lib/file/FileReader.js
- /Users/cdaringe/src/factorio-ts/packages/json-schema-producer/node_modules/happy-dom/lib/window/Window.js
- /Users/cdaringe/src/factorio-ts/packages/json-schema-producer/node_modules/happy-dom/lib/index.js

indeed, whatwg-encoding is not listed as a dep of happy-dom directly

@capricorn86 capricorn86 self-assigned this Jan 3, 2021
capricorn86 added a commit that referenced this issue Jan 3, 2021
…whatwg-encoding

#189@patch: Adds missing dependency whatwg-encoding.
@capricorn86
Copy link
Owner

Thanks for reporting @cdaringe! 🙂

It has been fixed now. I am still not sure why the test didn't fail, but I will look into that in another task.

Read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v2.1.4

@cdaringe
Copy link
Author

cdaringe commented Jan 4, 2021

amazing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants