Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect dependency for @happy-dom/jest-environment. #139

Closed
CrOrc opened this issue Oct 26, 2020 · 2 comments
Closed

Incorrect dependency for @happy-dom/jest-environment. #139

CrOrc opened this issue Oct 26, 2020 · 2 comments
Assignees
@capricorn86

Comments

@CrOrc
Copy link

CrOrc commented Oct 26, 2020

Package: @happy-dom/jest-environment
Version: 1.10.4
Vue is in dependencies for @happy-dom/jest-environment.
It should be in devDependencies instead.
Link to package.json
@capricorn86
Copy link
Owner

Thank you for reporting @CrOrc! I will fix it as soon as possible.

capricorn86 added a commit that referenced this issue Nov 10, 2020
@capricorn86
#139@patch: Changes Vue to be a devDependency as it is only used for …
c2fd682 
…testing.
@capricorn86 capricorn86 self-assigned this Nov 10, 2020
capricorn86 added a commit that referenced this issue Nov 10, 2020
@capricorn86
Merge pull request #148 from capricorn86/task/139-incorrect-dependenc…
8516ccc 
…y-for-happy-dom-jest-environment

#139@patch: Changes Vue to be a devDependency as it is only used for …
@capricorn86
Copy link
Owner

@CrOrc the bug has been fixed 🙂

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v1.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@capricorn86 capricorn86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CrOrc @capricorn86