You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In today's world, if a memoized function errors on initial call, it will error on all future calls. I would have expected the memoization to only occur on success. This seems like a reasonable assumption given that a typical use-case for an async.memoize would be an external call.
If the sqs queue has not been fully initialized by the time getQueueUrl is invoked initially, all future invocations of getQueueUrl will fail, even after the queue has been fully initialized.
I would be happy to either create a pull request to only memoize on success or update the documentation to clarify that the function will be memoized regardless of success or error.
The text was updated successfully, but these errors were encountered:
This would be a breaking change.
In today's world, if a memoized function errors on initial call, it will error on all future calls. I would have expected the memoization to only occur on success. This seems like a reasonable assumption given that a typical use-case for an async.memoize would be an external call.
Example case:
If the sqs queue has not been fully initialized by the time
getQueueUrl
is invoked initially, all future invocations ofgetQueueUrl
will fail, even after the queue has been fully initialized.I would be happy to either create a pull request to only memoize on success or update the documentation to clarify that the function will be memoized regardless of success or error.
The text was updated successfully, but these errors were encountered: