Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust styles in the Bash integration #429

Merged
merged 5 commits into from
Jul 21, 2024
Merged

Adjust styles in the Bash integration #429

merged 5 commits into from
Jul 21, 2024

Conversation

akinomyoga
Copy link
Contributor

Different styles and conventions are mixed in the Bash integration script, so I'd like to normalize them. See each commit message for each fix.

@akinomyoga
Use "$MCFLY_PATH" to call "mcfly" in Bash
e4481ec
@akinomyoga
Use glob matching and arithmetic comparison in Bash
9833b9c
@akinomyoga
Normalize the styles of "if" and "[[ ... ]]" in Bash
1cdcc66 
Different styles are mixed in the code:

- "if ...<newline>then" vs "if ...; then"
- [[ "$quoted" ... ]] vs [[ $not_quoted ... ]]
- [[ x = y ]] vs [[ x == y ]]
- "if ... fi;<newline>" vs "if ... fi<newline>"

This patch normalizes them to the latter styles.
@akinomyoga
Suppress SC2145 by "... ${array[*]}" instead of "... ${array[@]}"
7f41205
@akinomyoga
Use "command" to call external commands in Bash
f04825f
@akinomyoga akinomyoga mentioned this pull request Jul 17, 2024
Merged
@cantino cantino merged commit b8d1740 into cantino:master Jul 21, 2024
19 checks passed
@cantino
Copy link
Owner

cantino commented Jul 21, 2024

Thanks!

@akinomyoga akinomyoga deleted the bash-style branch July 21, 2024 19:37
@akinomyoga
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akinomyoga @cantino