Add defensive checks for null frame
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the PR, it looks good for me and I am happy to merge it. |
cansik
approved these changes
Oct 21, 2023
| DepthFrame frame = frames.getDepthFrame(); | ||
| depthStream.updateDepthData(frame); | ||
| frame.release(); | ||
| if (frames != null) { |
There was a problem hiding this comment.
So this means that the depthStream won't be updated if the frame is null and we get the same depth data back? I guess for stability this is good but it could be misleading for the user. But I think for now this is ok.
There was a problem hiding this comment.
That is my understanding. I think that I've been running into these errors because I'm running Realsense updates in a separate thread. Receiving an occasional frame of cached data seems better to me than potential multithreading-related errors.
|
Thank you! I'll test the new release today 🙌 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted in this issue, I was experiencing many null pointer exceptions while running the Realsense library in a thread. I've added null checks before using the
frameobjects, which were causing exceptions if they were null. This has solved the errors I was seeing, and hopefully doesn't have any negative impacts