Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

remove Wizard.done() #38

Merged
merged 1 commit into from
Apr 27, 2023
Merged

remove Wizard.done() #38

merged 1 commit into from
Apr 27, 2023

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Apr 27, 2023

@jpnurmi
Copy link
Contributor

jpnurmi commented Apr 27, 2023

Presumably, we can remove all of these too:

$ git grep -i done
lib/src/route.dart:/// The signature of [WizardRoute.onDone] callback.
lib/src/route.dart:typedef WizardDoneCallback = FutureOr<void> Function(Object? result);
lib/src/route.dart:    this.onDone,
lib/src/route.dart:  /// The callback invoked when the wizard is done.
lib/src/route.dart:  final WizardDoneCallback? onDone;
lib/src/scope.dart:  /// Returns `true` if the wizard is done.
lib/src/scope.dart:  bool get isDone => context.flow<List<WizardRouteSettings>>().completed;
lib/src/wizard.dart:  /// - [WizardScopeState.done]
lib/src/wizard.dart:  /// - [WizardScopeState.done]
test/wizard_router_test.dart:  Route? done;
test/wizard_router_test.dart:    done = null;
test/wizard_router_test.dart:    expect(observer.done, isNull);
test/wizard_router_test.dart:    expect(observer.done, isNull);
test/wizard_router_test.dart:    expect(observer.done, isNull);
test/wizard_router_test.dart:    expect(observer.done, isNull);

Copy link
Contributor

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@d-loose d-loose merged commit 6bbb8b5 into canonical:main Apr 27, 2023
@d-loose d-loose deleted the remove-done branch April 27, 2023 10:45
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants