Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: suggest fips-updates instead of fips #3389

Open
wants to merge 1 commit into
base: docs
Choose a base branch
from

Conversation

renanrodrigo
Copy link
Member

Why is this needed?

This PR solves all of our problems because we now recommend fips-updates, as fips is deprecated from Jammy

Fixes: #3388


  • (un)check this to re-run the checklist action

fips itself is deprecated from jammy

Signed-off-by: Renan Rodrigo <renanrodrigo@canonical.com>
@renanrodrigo renanrodrigo requested a review from s-makin February 10, 2025 14:06
@renanrodrigo
Copy link
Member Author

@henrycoggillcnc please take a look and see if the text fits

@github-actions github-actions bot added the docs label Feb 10, 2025
Comment on lines +44 to +51
.. note::

``fips-updates`` is the recommended way of enabling FIPS, as it will bring
the FIPS-compliant packages with security updates and coverage. There is
also a ``fips`` service, which has only the certified packages, *without
further security updates*, but that is deprecated from Ubuntu 22.04 (Jammy
Jellyfish) onward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content above this note is really confusing, because there is a difference between fips and fips-updates, and we're installing but referring to the other.

I think this note needs to be the introduction to the page as body text, and not a note, because that makes it clearer why there is this confusion.

Better would be to move the note (as mentioned) but also change the references to FIPS throughout the document to "FIPS with updates" or however we want to call it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is a product decision. From Jammy onwards, fips does not even exist, and the concept of "enabling FIPS" is achieved using the fips-updates service. We don't want people enabling fips. @henrycoggillcnc can explain it better if needed

@@ -54,7 +63,7 @@ If you wish to disable FIPS, you can use the following command:

.. code-block:: bash

sudo pro disable fips
sudo pro disable fips-updates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the difficulty in removing fips also apply to fips-updates?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants