Run spread tests on noble too #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 84.63% 94.12% +9.48%
==========================================
Files 18 18
Lines 3404 3404
==========================================
+ Hits 2881 3204 +323
+ Misses 443 127 -316
+ Partials 80 73 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ac32718 to
aae0c0d
Compare
ae61081 to
3b0c1f3
Compare
e92e19d to
17c0c06
Compare
aaa401a to
9b39852
Compare
|
@sil2100 this is ready for review. Current failures are previously known ones I need to address in other PRs. The hostname setup is a bit hacky but is needed to properly run on 24.04+ on GCE (see https://documentation.ubuntu.com/gcp/en/latest/google-how-to/gce/set-hostname-using-cloudinit/) |
e308212 to
d016dfb
Compare
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
d016dfb to
da0d486
Compare
This may be left out by some interrupted adhoc tools. We do not want to version this by mistake. Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
No change in configuration so this is mainly to avoid getting used to seeing the check in CI fail. Signed-off-by: Paul Mars <paul.mars@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spread tests on noble and remove those on lunar.