-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR-5793 - Rework tests #161
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
baa4a2d
Rework tests
upils 1e68429
Ignore TestFailedGetPreseededSnaps in short mode
upils 0112f5d
Declare test able to run in parallel in the same package
upils 7a8d709
Split short/long tests
upils 678172b
Try to avoid duplicate CI jobs
upils 88665be
Try composite action to upload coverage
upils ae70010
Fix composite action
upils 38ee178
Clean some more defer
upils 50377c9
Fix github action path, again
upils 68cfb36
Add a basicChrooter to generic a common basic chroot
upils 4e02ac8
basicChrooter working
upils 3352d98
Simplify coverage upload
upils 53f12ab
Document and refactor basicChroot
upils 12d90f2
Use getBasicChroot wherever we can
upils b735fa1
Make sure defaults are applied when creating basicChroot
upils 4d31a4d
Update changelog and snapcraft.yaml
upils 0162d00
Use codecov token to upload coverage more reliably
upils File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Split short/long tests
- Loading branch information
commit 7a8d709c95539f1edc2a0a274685c9d21af4ef8a
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work? Since I see some conditionals for when
testing.Short()
is on. But does this mean that the long tests execute all the long AND short tests? Or is there a way to just get the long ones run?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the "long tests" are also executing the short ones. Unfortunately there is no practical way to exclude short ones. But since short ones takes less than 10s this is negligible comparing to the long ones. Moreover, since I upload the coverage in both cases, this is nice that long tests also cover the short ones so the final coverage is the complete one (and not only the coverage of long tests).