Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the number of consecutive failed provsion attempts on the agents page #306

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

plars
Copy link
Collaborator

@plars plars commented Jul 10, 2024

Description

Display a warning icon, count, and tooltip for the icon with details if the agent has failed more than 1 consecutive provision attempt for the most recent runs.

Also, columns are sortable now, including the one for the failure counts.

image

Resolved issues

CERTTF-354

Documentation

N/A

Web service API changes

N/A

Tests

Tested locally (see screenshot) and also added unit tests

@plars plars requested a review from a team July 10, 2024 19:27
@plars
Copy link
Collaborator Author

plars commented Jul 18, 2024

I've added some additional things that were asked for when this story was expanded. Specifically:

  • Have the warning for any number of failed attempts, not just >1
  • also have a streak count for successful provision attempts
  • failure rate for provisioning history on the agent details page with configurable date range

Here's a screen shot with the date range picker and new field on the details page. The date pickers automatically get filled in with the current date as the stop and 2 days ago as the start. If you specify a new date range and hit refresh, it will reload the page with the new values. The specified date range will also be applied to the table of provision results, so that you see the same data that is considered in the provision success rate.

image

Copy link

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very useful, just a few mostly code style comments

server/tests/test_views.py Show resolved Hide resolved
server/src/api/v1.py Show resolved Hide resolved
server/src/static/assets/js/filter.js Show resolved Hide resolved
server/src/static/assets/js/filter.js Show resolved Hide resolved
server/src/static/assets/js/filter.js Show resolved Hide resolved
server/src/static/assets/js/filter.js Show resolved Hide resolved
server/src/static/assets/js/filter.js Show resolved Hide resolved
server/src/templates/agents.html Outdated Show resolved Hide resolved
Copy link

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the comments are not blockers, so to me this is good to merge

@plars plars merged commit 8bd2a0f into main Jul 23, 2024
1 check passed
@plars plars deleted the agent-consecutive-provision-fail-counts branch July 23, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants