-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display the number of consecutive failed provsion attempts on the agents page #306
Conversation
I've added some additional things that were asked for when this story was expanded. Specifically:
Here's a screen shot with the date range picker and new field on the details page. The date pickers automatically get filled in with the current date as the stop and 2 days ago as the start. If you specify a new date range and hit refresh, it will reload the page with the new values. The specified date range will also be applied to the table of provision results, so that you see the same data that is considered in the provision success rate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very useful, just a few mostly code style comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the comments are not blockers, so to me this is good to merge
Description
Display a warning icon, count, and tooltip for the icon with details if the agent has failed more than 1 consecutive provision attempt for the most recent runs.
Also, columns are sortable now, including the one for the failure counts.
Resolved issues
CERTTF-354
Documentation
N/A
Web service API changes
N/A
Tests
Tested locally (see screenshot) and also added unit tests