Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to the reference section about provision_data #232

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

plars
Copy link
Collaborator

@plars plars commented Mar 21, 2024

Description

  • move the maas storage custom config documentation out to the main documentation directory
  • reformat the maas storage custom config docs and link to TOC
  • add per-device-connector documentation for all the support provision_data options we currently support

Resolved issues

Resolves one part of CERTTF-298

Documentation

yes

Tests

Built locally using make html from the docs directory

@plars plars requested review from tang-mm and a team March 21, 2024 21:18
@tang-mm
Copy link
Contributor

tang-mm commented Mar 22, 2024

I appended some edits here directly to fix the doc checks, mainly changing the key names to use the code syntax so the spelling check will ignore them.

I also updated the tutorial to use the "simpler" maas provision_data fields and then point to the device_connector document (a1a92dd). Please check if it's appropriate

@tang-mm tang-mm requested a review from a team March 22, 2024 03:50
@plars
Copy link
Collaborator Author

plars commented Mar 22, 2024

Thanks, those look good to me, but I think we need another reviewer.

Copy link

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@plars plars merged commit b383c10 into main Mar 26, 2024
5 checks passed
@plars plars deleted the device-connector-provision-data-docs branch March 26, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants