Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add hp_oemscript device connector #177

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

plars
Copy link
Collaborator

@plars plars commented Dec 15, 2023

Description

This adds oemscript provisioning for hp devices explicitly. Functionally, there's no difference right now between this and the lenovo one since both require the ubr flag, but that might change in the future.

Resolved issues

Allows hp oem systems to be configured for provisioning oem images.

Documentation

Added a mention of it in the reference section of the docs like the other types have.

Tests

This was tested a while back by Kevin, though I think at the time he was just using the lenovo one. Since all that's happening here are string changes, I don't suspect there should be a problem, but it might be useful to try it on one system first before rolling it out to all the others.

@plars plars requested a review from a team December 15, 2023 14:38
Copy link
Collaborator

@mz2 mz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@plars plars merged commit e7450ba into main Dec 15, 2023
5 checks passed
@plars plars deleted the add-hp-oemscript-device-connector branch December 15, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants