feat: ephemeral deployment #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @WhimsyWolfe Thank you for your contribution! |
|
Hi @WhimsyWolfe and thank you for your contribution. As you correctly mentioned in your description, this PR will have to wait for the next |
|
Hi @WhimsyWolfe, new version of gomaasclient released today and it is already used by terraform-provider-maas. Could you please rebase your PR on latest master so that we can proceed with the review? 🙂 |
|
Let's also make the CI happy by running a |
…/bin/tfplugindocs generate --provider-name terraform-provider-maas rendering website for provider "terraform-provider-maas" (as "terraform-provider-maas") copying any existing content to tmp dir exporting schema from Terraform compiling provider "maas" using Terraform CLI binary from PATH if available, otherwise downloading latest Terraform CLI binary running terraform init getting provider schema generating missing templates generating missing resource content generating new template for "maas_network_interface_link" generating new template for "maas_network_interface_physical" generating new template for "maas_tag" generating new template for "maas_user" generating new template for "maas_dns_record" generating new template for "maas_fabric" generating new template for "maas_network_interface_bridge" generating new template for "maas_instance" generating new template for "maas_network_interface_bond" generating new template for "maas_vlan" generating new template for "maas_network_interface_vlan" generating new template for "maas_vm_host" generating new template for "maas_block_device" generating new template for "maas_device" generating new template for "maas_dns_domain" generating new template for "maas_subnet" generating new template for "maas_subnet_ip_range" generating new template for "maas_vm_host_machine" generating new template for "maas_machine" generating new template for "maas_resource_pool" generating new template for "maas_space" generating missing data source content generating new template for data-source "maas_network_interface_physical" generating new template for data-source "maas_resource_pool" generating new template for data-source "maas_subnet" generating new template for data-source "maas_vlan" generating new template for data-source "maas_device" generating new template for data-source "maas_fabric" generating new template for data-source "maas_machine" generating missing function content generating missing provider content provider "terraform-provider-maas" template exists, skipping rendering static website cleaning rendered website dir removing directory: "data-sources" removing file: "index.md" removing directory: "resources" rendering templated website to static markdown rendering "data-sources/device.md.tmpl" rendering "data-sources/fabric.md.tmpl" rendering "data-sources/machine.md.tmpl" rendering "data-sources/network_interface_physical.md.tmpl" rendering "data-sources/resource_pool.md.tmpl" rendering "data-sources/subnet.md.tmpl" rendering "data-sources/vlan.md.tmpl" rendering "index.md.tmpl" rendering "resources/block_device.md.tmpl" rendering "resources/device.md.tmpl" rendering "resources/dns_domain.md.tmpl" rendering "resources/dns_record.md.tmpl" rendering "resources/fabric.md.tmpl" rendering "resources/instance.md.tmpl" rendering "resources/machine.md.tmpl" rendering "resources/network_interface_bond.md.tmpl" rendering "resources/network_interface_bridge.md.tmpl" rendering "resources/network_interface_link.md.tmpl" rendering "resources/network_interface_physical.md.tmpl" rendering "resources/network_interface_vlan.md.tmpl" rendering "resources/resource_pool.md.tmpl" rendering "resources/space.md.tmpl" rendering "resources/subnet.md.tmpl" rendering "resources/subnet_ip_range.md.tmpl" rendering "resources/tag.md.tmpl" rendering "resources/user.md.tmpl" rendering "resources/vlan.md.tmpl" rendering "resources/vm_host.md.tmpl" rendering "resources/vm_host_machine.md.tmpl"
|
I didn't see that in the make file. I'll keep that in mind next time. |
skatsaounis
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
LGTM +1 Thank you @WhimsyWolfe for the contribution and the patience!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to deploy maas_instances as an ephemeral deployment. This PR relies on the gomaasclient PR #87