This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
instance attribute support for charm_tracing forward-declared definitions #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
sed-i and
simskij
as code owners
June 14, 2024 13:49
ca-scribner
reviewed
Jun 19, 2024
ca-scribner
reviewed
Jun 19, 2024
…n value is unexpected or raises
mmkay
reviewed
Jun 20, 2024
mmkay
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muuuuch nicer, thanks @ca-scribner!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for charm_tracing to grab the endpoint and cert it needs from instance attributes instead of properties and methods.
This is a nicety which in combination with #135 means any charm can enable/disable charm tracing and correctly configure it with/without TLS with a single line of code (plus the decorator).
before:
after:
Additionally: