Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate stories from mdx to csf #108

Closed
wants to merge 1 commit into from
Closed

refactor: migrate stories from mdx to csf #108

wants to merge 1 commit into from

Conversation

rsmelo92
Copy link

@rsmelo92 rsmelo92 commented Jan 8, 2024

Done

This PR migrate component stories from MDX to CSF, please check issue #107 for more details

  • Migrated all stories 1:1 from MDX to CSF
  • Added a default layout for Docs on preview.js
  • Added some types so docs won't show any when rendering the argtypes

QA

QA steps

  • Run the project
  • Open components stories
  • Check that the behaviors haven't changed
  • Open the code
  • Check that there is less code, less cognitive overload and it has improved

Fixes

Fixes: #107 .

@webteam-app
Copy link

rsmelo92 is not a collaborator of the repo

@steverydz
Copy link
Collaborator

Hi @rsmelo92. Thanks for the PR!

We appreciate the effort, however this isn't a change we're looking to make at this time.

@steverydz steverydz closed this Jan 8, 2024
@rsmelo92 rsmelo92 deleted the rsmelo92/migrate-from-mdx-to-csf branch January 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: Migrate to CSF stories with autodocs
3 participants