Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper for operator-framework focused interface libraries to be used in reactive charms #1

Merged
merged 20 commits into from
Jan 4, 2021

Conversation

johnsca
Copy link
Contributor

@johnsca johnsca commented Dec 5, 2020

Library to allow interface API libraries designed primarily for the operator framework to be registered with the legacy reactive framework so that they can be used in reactive charms with minimal effort on the interface API library maintainer (primarily just by implementing a manage_flags method which will only be called when used in a reactive charm). The docs now contain a complete, albeit simple, example of how this is intended to be used.

This depends on canonical/charms.reactive#227 (but can use it from the branch until it's released).

Things that are missing / known to be broken:

Had to switch to LXD instead of MicroK8s because of the way
layer:caas-base builds the "venv" for K8s charms. Specifically, it drops
all package metadata so entry points don't work at all. It's also
missing all of the improvements to the composite wheelhouse.txt
processing that were added to charms.reactive. Will need to fix those
things in that layer.
@johnsca
Copy link
Contributor Author

johnsca commented Dec 5, 2020

I'll have to sort out the GitHub Workflow issue for the integration test, but I did get a passing run locally, at least:

========== 1 passed in 753.61s (0:12:33) ==========
_____________________ summary _____________________
  integration: commands succeeded
  congratulations :)

@johnsca johnsca changed the title Initial implementation of library Helper for operator-framework focused interface libraries to be used in reactive charms Dec 7, 2020
@johnsca johnsca merged commit 6ae1dab into main Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants