-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper for operator-framework focused interface libraries to be used in reactive charms #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to switch to LXD instead of MicroK8s because of the way layer:caas-base builds the "venv" for K8s charms. Specifically, it drops all package metadata so entry points don't work at all. It's also missing all of the improvements to the composite wheelhouse.txt processing that were added to charms.reactive. Will need to fix those things in that layer.
|
kwmonroe
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library to allow interface API libraries designed primarily for the operator framework to be registered with the legacy reactive framework so that they can be used in reactive charms with minimal effort on the interface API library maintainer (primarily just by implementing a
manage_flags
method which will only be called when used in a reactive charm). The docs now contain a complete, albeit simple, example of how this is intended to be used.This depends on canonical/charms.reactive#227 (but can use it from the branch until it's released).
Things that are missing / known to be broken:
README / documentationlayer:caas-base