Pass through tag-prefix to the canonical/charming-actions/release-cha… #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arturo-seijas @weiiwang01 @jdkandersson Any chance this could get a look, I'll have to promote my charms manually without this |
|
this has blocked the last few promotion runs: |
|
Assigned the PR |
weiiwang01
approved these changes
Dec 20, 2024
arturo-seijas
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When a charm repo contains multiple charms, the promote-charm action fails because the charms have been tagged with a
<charm>-<rev>tag-prefix` needed during the promote jobDetails