cli:apply: Ignore udevadm errors triggering devices (LP: #2095203) #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes LP: #2095203 Signed-off-by: Wesley Hershberger <wesley.hershberger@gmail.com>
slyon
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Thanks for your contribution! The CI is all green, and didn't find any unrelated side-effects.
LGTM! Especially with all the due diligence done in canonical/snapd#11056 (review)
9927427 to
8d1638b
Compare
|
Thanks, I appreciate the quick turnaround here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LP: #2095203
Description
This is a first draft to get the discussion going as requested in the LP. Based on the
udevadmteardown from the related snapd PR, I think this is very unlikely to cause a regression.Checklist
make checksuccessfully.make check-coverage).New/changed keys in YAML format are documented.(Optional) Adds example YAML for new feature.