-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
networkd: reload/reconfigure #200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 98.98% 99.00% +0.01%
==========================================
Files 54 54
Lines 8215 8316 +101
==========================================
+ Hits 8132 8233 +101
Misses 83 83
Continue to review full report at Codecov.
|
208d50b
to
2b4f035
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this looks smooth. Thanks! (just one inline enhancement proposed)
make use of list.extend() instead of individual list.append()s Co-authored-by: Łukasz Zemczak <sil2100@vexillium.org>
Description
Replace the calls of
systemctl stop/start systemd-networkd.service
withnetworkctl reload && networkctl reconfigure ...
during the execution ofnetplan apply
. The devices to be reconfigured are currently all interfaces managed by systemd-networkd, as read fromnetworkctl
. This makes the whole restart/apply process quicker and avoids network interruptions for netplan's networkd backend.The reload & reconfigure commands are available as of systemd v244.
In addition to the Apply-CLI changes, corresponding methods in
utils.py
are updated/refactored and the unit-test coverage is being improved.Checklist
make check
successfully.make check-coverage
).