-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-4375] Add cluster manual re-join handler #560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
requested review from
paulomach,
shayancanonical and
carlcsaposs-canonical
January 21, 2025 15:04
sinclert-canonical
force-pushed
the
sinclert/4375/cluster-manual-rejoin
branch
from
January 22, 2025 09:44
c851105
to
37b81ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sinclert-canonical
force-pushed
the
sinclert/4375/cluster-manual-rejoin
branch
from
January 22, 2025 13:45
37b81ac
to
175dc6c
Compare
carlcsaposs-canonical
approved these changes
Jan 22, 2025
PR waiting on #553 to be merged in order to update |
sinclert-canonical
force-pushed
the
sinclert/4375/cluster-manual-rejoin
branch
from
January 24, 2025 08:37
175dc6c
to
e0431be
Compare
Branch rebased from |
paulomach
approved these changes
Jan 24, 2025
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to manually re-join a MySQL replica that has gone
OFFLINE
, to the cluster, whenever MySQL 8.0.21+ auto re-join attempts have been exhausted.Description
There are edge cases where a MySQL instance that has lost connection to the cluster it originally belong to (i.e.
OFFLINE
), exhaust its automatic retries (by default 3 retries, with 5 mins between each, starting with MySQL 8.0.21). For those cases, a manual re-join should be performed.Depends on #563.