-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPE-2653 profile limit option #318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomach
requested review from
shayancanonical,
carlcsaposs-canonical and
taurus-forever
October 11, 2023 14:40
shayancanonical
previously approved these changes
Oct 11, 2023
carlcsaposs-canonical
previously approved these changes
Oct 12, 2023
taurus-forever
previously approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…eature/dpe-2653-profile-limit-option # Conflicts: # lib/charms/mysql/v0/mysql.py # poetry.lock # src/charm.py
paulomach
dismissed stale reviews from taurus-forever and carlcsaposs-canonical
via
October 16, 2023 18:46
056c5f8
carlcsaposs-canonical
previously approved these changes
Oct 17, 2023
…nonical/mysql-k8s-operator into feature/dpe-2653-profile-limit-option
carlcsaposs-canonical
requested changes
Oct 20, 2023
paulomach
requested review from
carlcsaposs-canonical,
taurus-forever and
shayancanonical
October 20, 2023 13:52
carlcsaposs-canonical
approved these changes
Oct 20, 2023
taurus-forever
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tnx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of vm PR#331