Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce InputEventTransformer to read and synthesize input events #3754

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Introduce InputEventTransformer to read and synthesize input events #3754

wants to merge 5 commits into from

Conversation

tarek-y-ismail
Copy link
Contributor

@tarek-y-ismail tarek-y-ismail commented Feb 11, 2025 •
edited
Loading

Some notes:

  1. The latter half of this PR (the accessibility manager demo) is just for making sure its functionality works properly. I will move this commit to the mousekeys PR after this one is approved.
  2. Currently, there's a segfault when shutting down mir thrown somewhere while destructing SeatInputDeviceTracker::touch_visualizer. It's not entirely clear what's the cause, but I have a "workaround" for it. I'm still trying to find the root cause
  3. This is likely to change as the usage requirements change when implementing mousekeys.

@tarek-y-ismail tarek-y-ismail force-pushed the MIRENG-888/input-event-transformer branch from f503e0e to 32d7607 Compare February 12, 2025 08:31
@tarek-y-ismail tarek-y-ismail force-pushed the MIRENG-888/input-event-transformer branch 7 times, most recently from 84083bc to 3742e4b Compare February 12, 2025 12:30
@tarek-y-ismail tarek-y-ismail marked this pull request as ready for review February 12, 2025 14:16
@tarek-y-ismail tarek-y-ismail requested a review from a team as a code owner February 12, 2025 14:16
@tarek-y-ismail tarek-y-ismail force-pushed the MIRENG-888/input-event-transformer branch from 3742e4b to 1f9daba Compare February 13, 2025 15:42
AlanGriffiths
AlanGriffiths requested changes Feb 13, 2025
View reviewed changes
@tarek-y-ismail tarek-y-ismail force-pushed the MIRENG-888/input-event-transformer branch from df86bf8 to 3344a7c Compare February 14, 2025 13:24
@tarek-y-ismail
Introduce InputEventTransformer
c49650a 
Sets up the needed infrastructure to listen to input events and
synthesize new input events in response.
@tarek-y-ismail
Demo input event transformations with AccessibilityManager
77d7666
@tarek-y-ismail
Clean up symbols
249e1f6 
Move `enable_mouse_keys_opt` to the 2.20 stanza
Move `AccessibilityManager::*` and related symbols to the 2.20 stanza
Add symbols for `InputEventTransformer`
@tarek-y-ismail
Return true and exit immediately from InputEventTransformer::handle
8335b1a 
when an event is handled

Previously, we'd continue running other handlers, and we'd return
`false`, letting other dispatchers run (not the intended behavior)
@tarek-y-ismail tarek-y-ismail force-pushed the MIRENG-888/input-event-transformer branch from da94306 to 8335b1a Compare February 18, 2025 10:15
@tarek-y-ismail
Copy link
Contributor Author

tarek-y-ismail commented Feb 20, 2025 •
edited
Loading

@AlanGriffiths pretty sure I'm done with this at the moment. Feel free to review. I've kept the "demo" for testing, but I'll drop it once the PR is approved.

The only "thing" that might be missing is figuring out why we crash during destruction/shutdown inside shared pointer code. Will investigate that more tomorrow.

Edit: Turns out the issue only occurs with #3757 only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths Awaiting requested review from AlanGriffiths

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarek-y-ismail @AlanGriffiths