Improve Firefox surface.frame event quirk
#3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to move the `executor_send_frame_callback` into its consumer; this obviously doesn't work if it's `const`.
surface.frame event quirk
|
I think we might also want to fix issue #3739 while we're here, but I didn't want to block this on that. I've had a look, and it's not much work, but there's some subtlety around |
We currently queue a `send_frame_events()` 16ms after receiving a `surface.commit()` with no buffer but that requests a frame event. When `send_frame_events()` is triggered it sends *all* the frame events at the time of trigger; this results in us sending frame events at a sub-optimal time and breaks the way that WLCS uses the frame event to determine when a buffer has been used. Instead, maintain a separate `heartbeat_quirk_frame_events` list that gets sent by the 16ms timer.
Oops! The `FrameExecutor` (annoyingly!) doesn't execute on the Wayland event loop. We need a second bounce to get the `send_frame_callbacks()` call there.
c028ed1 to
6c88bcd
Compare
|
Ok! The problem was that the new code was broken! (it was never triggered). The WpViewporter tests happen to use buffer-less frame events, so that's why those broke. It seems that Firefox is more tolerant of not sending those events than it was (although, now that I've actually fixed it I can see that there are behavioural differences that just seemed like regular weirdness 🤷♀️ ) |
|
There's now also a WLCS test that catches this: canonical/wlcs#350 |
AlanGriffiths
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently queue a
send_frame_events()16ms after receivinga
surface.commit()with no buffer but that requests a frameevent.
When
send_frame_events()is triggered it sends all the frameevents at the time of trigger; this results in us sending frame
events at a sub-optimal time and breaks the way that WLCS uses
the frame event to determine when a buffer has been used.
Instead, maintain a separate
heartbeat_quirk_frame_eventslistthat gets sent by the 16ms timer.