feature: remove mir cookie #3176
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3176 +/- ##
==========================================
- Coverage 77.85% 77.81% -0.05%
==========================================
Files 1070 1062 -8
Lines 74893 74626 -267
==========================================
- Hits 58311 58072 -239
+ Misses 16582 16554 -28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
This looks good to me.
We might want something similar for xdg-activation, but since that has a client-requests-token -> server-generates-token loop we shouldn't need any of the cookie-for-every-event infrastructure this removes.
If some of the code turns out to be useful there, we can easily fish it out of history.
There was a problem hiding this comment.
I think this header belongs in include/common, not include/core - see where the function is implemented.
| @@ -411,7 +411,6 @@ def _report(publish, symbol): | |||
| miral::toolkit::mir_input_event_get_pointer_event*; | |||
| miral::toolkit::mir_input_event_get_touch_event*; | |||
| miral::toolkit::mir_input_event_get_type*; | |||
| miral::toolkit::mir_input_event_has_cookie*; | |||
There was a problem hiding this comment.
We should be bumping ABI, not dropping symbols without changing soname
There was a problem hiding this comment.
Yeah this might be one that I don't understand. Should I leave all of the .map files unchanged, or am I supposed to remove the symbols from them now?
Also, is there any simple mechanism for bumping the so names that need to be bumped?
There was a problem hiding this comment.
This looks good except for the symbol/soname versioning. That is addressed in a dependent PR: #3178.
I think the best approach is to merge that into this PR before landing. But marking my approval
Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
|
@AlanGriffiths FYI, it appears that the failing Fedora tests are failing on main too. |
What's new?