Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify code #3174

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Simplify code #3174

merged 2 commits into from
Jan 9, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

Many years ago we tried to get some libinput_event_touch_ functions upstreamed to libinput, but they were rejected. Ubuntu no longer carries the patch that implements them.

There are simpler ways to do what this code did (e.g. resolve the possible library functions at compile time or make the function pointers global) but, as the functions are never available, it doesn't need to do it anyway.

The new version will give a compile error if the functions are introduced into libinput and we can fix the code appropriately if that happens.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc6864b) 77.86% compared to head (719e71c) 77.86%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3174      +/-   ##
==========================================
- Coverage   77.86%   77.86%   -0.01%     
==========================================
  Files        1070     1080      +10     
  Lines       74917    75341     +424     
==========================================
+ Hits        58334    58664     +330     
- Misses      16583    16677      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I was sure I'd reviewed this before!

Yeah, this code was weird when I looked at it recently, too 😁

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit a632621 Jan 9, 2024
35 checks passed
@AlanGriffiths AlanGriffiths deleted the simpler-hack branch January 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants