-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding license - Apache 2.0 #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing copyright.
LICENSE
Outdated
same "printed page" as the copyright notice for easier | ||
identification within third-party archives. | ||
|
||
Copyright [yyyy] [name of copyright owner] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright 2018 Canonical, Ltd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yikes. nice catch. shame on you @ktsakalozos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we know who reeds the license files...
Fixes #123 |
You're all actually wrong, you shouldn't modify the license file that way. That's the template to show you how to add it to the top of files :) |
@marcoceppi is right on not having to update the copyright info on this file. Seems that each file in the project can be considered a separate IP and as such it should bare a notice with a pointer to the license and also mention the copyright. We will not be adding the license & copyright notice on each file at this point. I am not a lawyer but it seems to me it is best to mention that Canonical holds the copyright in the license template rather than not mention it at all. This is what we have been doing on other github projects. @marcoceppi if this resolution is not satisfactory please reopen #123 |
I'd use this as an example https://github.com/CitizensFoundation/your-priorities-app/blob/master/LICENSE.md While the formatting is a bit off, it includes the unmodified license file and a copyright call. |
No description provided.