Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs link to cluster annotations #254

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Jan 17, 2025

Overview

  • rehome the link to the annotations reference guide

@addyess addyess requested a review from a team as a code owner January 17, 2025 14:18
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyess addyess requested a review from nhennigan January 23, 2025 15:21
Copy link
Contributor

Test coverage for 6d3a4f9

coverage-report: install_deps /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> /home/runner/.local/share/uv/tools/tox/bin/uv pip install 'coverage[toml]'
coverage-report: commands[0] /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> coverage report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
lib/charms/k8s/v0/k8sd_api_manager.py     286     29    90%
src/charm.py                              509    266    48%
src/cloud_integration.py                   80      3    96%
src/config/extra_args.py                   31      2    94%
src/containerd.py                         140     22    84%
src/cos_integration.py                     33     12    64%
src/events/update_status.py                68     24    65%
src/inspector.py                           41      4    90%
src/kube_control.py                        43     32    26%
src/literals.py                            27      0   100%
src/protocols.py                           28      5    82%
src/reschedule.py                          77      4    95%
src/snap.py                               193     29    85%
src/token_distributor.py                  181    109    40%
src/upgrade.py                            108     48    56%
-----------------------------------------------------------
TOTAL                                    1845    589    68%
coverage-report: OK (0.34=setup[0.03]+cmd[0.31] seconds)
congratulations :) (0.40 seconds)

Static code analysis report

Run started:2025-01-24 15:02:41.970536

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3931
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@addyess addyess merged commit 9f41270 into main Jan 25, 2025
70 checks passed
@addyess addyess deleted the KU-2450/docs/annotations-link-update branch January 25, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants