generated from canonical/is-charms-template-repo
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow charms to remove node labels via config (#224) #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow charms to remove node labels via config * Linting mistake * Update to tip of charm-lib-node-base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 136 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
0 | 66 | 70 | 0 |
Click to see the invalid file list
- charms/worker/build-snap-installation.sh
- charms/worker/charmcraft.yaml
- charms/worker/k8s/build-snap-installation.sh
- charms/worker/k8s/charmcraft.yaml
- charms/worker/k8s/scripts/rules-patches/core-alert-rules.patch
- charms/worker/k8s/scripts/update_alert_rules.py
- charms/worker/k8s/scripts/update_dashboards.py
- charms/worker/k8s/src/charm.py
- charms/worker/k8s/src/cloud_integration.py
- charms/worker/k8s/src/config/extra_args.py
- charms/worker/k8s/src/containerd.py
- charms/worker/k8s/src/cos_integration.py
- charms/worker/k8s/src/events/update_status.py
- charms/worker/k8s/src/inspector.py
- charms/worker/k8s/src/kube_control.py
- charms/worker/k8s/src/literals.py
- charms/worker/k8s/src/prometheus_alert_rules/kubePrometheus-prometheusRule.yaml
- charms/worker/k8s/src/prometheus_alert_rules/kubeStateMetrics-prometheusRule.yaml
- charms/worker/k8s/src/prometheus_alert_rules/kubernetesControlPlane-prometheusRule.yaml
- charms/worker/k8s/src/protocols.py
- charms/worker/k8s/src/reschedule.py
- charms/worker/k8s/src/snap.py
- charms/worker/k8s/src/token_distributor.py
- charms/worker/k8s/src/upgrade.py
- charms/worker/k8s/templates/cos_roles.yaml
- charms/worker/k8s/templates/ksm.yaml
- charms/worker/k8s/templates/snap_installation.yaml
- charms/worker/k8s/terraform/main.tf
- charms/worker/k8s/terraform/outputs.tf
- charms/worker/k8s/terraform/variables.tf
- charms/worker/k8s/terraform/versions.tf
- charms/worker/k8s/tests/unit/test_base.py
- charms/worker/k8s/tests/unit/test_cloud_integration.py
- charms/worker/k8s/tests/unit/test_config_options.py
- charms/worker/k8s/tests/unit/test_containerd.py
- charms/worker/k8s/tests/unit/test_inspector.py
- charms/worker/k8s/tests/unit/test_k8sd_api_manager.py
- charms/worker/k8s/tests/unit/test_reschedule.py
- charms/worker/k8s/tests/unit/test_snap.py
- charms/worker/k8s/tests/unit/test_token_distributor.py
- charms/worker/k8s/tests/unit/test_upgrade.py
- charms/worker/terraform/main.tf
- charms/worker/terraform/outputs.tf
- charms/worker/terraform/variables.tf
- charms/worker/terraform/versions.tf
- generate-src-docs.sh
- tests/integration/init.py
- tests/integration/conftest.py
- tests/integration/cos_substrate.py
- tests/integration/data/cos-offers-overlay.yaml
- tests/integration/data/k8s.profile
- tests/integration/data/microk8s.profile
- tests/integration/data/static-proxy-config.yaml
- tests/integration/data/test-bundle-ceph.yaml
- tests/integration/data/test-bundle-etcd.yaml
- tests/integration/data/test-bundle.yaml
- tests/integration/data/test_ceph/ceph-xfs-pvc.yaml
- tests/integration/data/test_ceph/pv-reader-pod.yaml
- tests/integration/data/test_ceph/pv-writer-pod.yaml
- tests/integration/grafana.py
- tests/integration/helpers.py
- tests/integration/prometheus.py
- tests/integration/test_ceph.py
- tests/integration/test_etcd.py
- tests/integration/test_k8s.py
- tests/integration/test_upgrade.py
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Test coverage for f445879
Static code analysis report
|
mateoflorido
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back ports #224 to release-1.32 branch