Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow charms to remove node labels via config (#224) #244

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Jan 10, 2025

Back ports #224 to release-1.32 branch

  • Allow charms to remove node labels via config
  • Linting mistake
  • Update to tip of charm-lib-node-base

* Allow charms to remove node labels via config

* Linting mistake

* Update to tip of charm-lib-node-base
@addyess addyess requested a review from a team as a code owner January 10, 2025 22:05
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 136 files.

Valid Invalid Ignored Fixed
0 66 70 0
Click to see the invalid file list
  • charms/worker/build-snap-installation.sh
  • charms/worker/charmcraft.yaml
  • charms/worker/k8s/build-snap-installation.sh
  • charms/worker/k8s/charmcraft.yaml
  • charms/worker/k8s/scripts/rules-patches/core-alert-rules.patch
  • charms/worker/k8s/scripts/update_alert_rules.py
  • charms/worker/k8s/scripts/update_dashboards.py
  • charms/worker/k8s/src/charm.py
  • charms/worker/k8s/src/cloud_integration.py
  • charms/worker/k8s/src/config/extra_args.py
  • charms/worker/k8s/src/containerd.py
  • charms/worker/k8s/src/cos_integration.py
  • charms/worker/k8s/src/events/update_status.py
  • charms/worker/k8s/src/inspector.py
  • charms/worker/k8s/src/kube_control.py
  • charms/worker/k8s/src/literals.py
  • charms/worker/k8s/src/prometheus_alert_rules/kubePrometheus-prometheusRule.yaml
  • charms/worker/k8s/src/prometheus_alert_rules/kubeStateMetrics-prometheusRule.yaml
  • charms/worker/k8s/src/prometheus_alert_rules/kubernetesControlPlane-prometheusRule.yaml
  • charms/worker/k8s/src/protocols.py
  • charms/worker/k8s/src/reschedule.py
  • charms/worker/k8s/src/snap.py
  • charms/worker/k8s/src/token_distributor.py
  • charms/worker/k8s/src/upgrade.py
  • charms/worker/k8s/templates/cos_roles.yaml
  • charms/worker/k8s/templates/ksm.yaml
  • charms/worker/k8s/templates/snap_installation.yaml
  • charms/worker/k8s/terraform/main.tf
  • charms/worker/k8s/terraform/outputs.tf
  • charms/worker/k8s/terraform/variables.tf
  • charms/worker/k8s/terraform/versions.tf
  • charms/worker/k8s/tests/unit/test_base.py
  • charms/worker/k8s/tests/unit/test_cloud_integration.py
  • charms/worker/k8s/tests/unit/test_config_options.py
  • charms/worker/k8s/tests/unit/test_containerd.py
  • charms/worker/k8s/tests/unit/test_inspector.py
  • charms/worker/k8s/tests/unit/test_k8sd_api_manager.py
  • charms/worker/k8s/tests/unit/test_reschedule.py
  • charms/worker/k8s/tests/unit/test_snap.py
  • charms/worker/k8s/tests/unit/test_token_distributor.py
  • charms/worker/k8s/tests/unit/test_upgrade.py
  • charms/worker/terraform/main.tf
  • charms/worker/terraform/outputs.tf
  • charms/worker/terraform/variables.tf
  • charms/worker/terraform/versions.tf
  • generate-src-docs.sh
  • tests/integration/init.py
  • tests/integration/conftest.py
  • tests/integration/cos_substrate.py
  • tests/integration/data/cos-offers-overlay.yaml
  • tests/integration/data/k8s.profile
  • tests/integration/data/microk8s.profile
  • tests/integration/data/static-proxy-config.yaml
  • tests/integration/data/test-bundle-ceph.yaml
  • tests/integration/data/test-bundle-etcd.yaml
  • tests/integration/data/test-bundle.yaml
  • tests/integration/data/test_ceph/ceph-xfs-pvc.yaml
  • tests/integration/data/test_ceph/pv-reader-pod.yaml
  • tests/integration/data/test_ceph/pv-writer-pod.yaml
  • tests/integration/grafana.py
  • tests/integration/helpers.py
  • tests/integration/prometheus.py
  • tests/integration/test_ceph.py
  • tests/integration/test_etcd.py
  • tests/integration/test_k8s.py
  • tests/integration/test_upgrade.py
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

Test coverage for f445879

coverage-report: install_deps /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> python -I -m pip install 'coverage[toml]'
coverage-report: commands[0] /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> coverage report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
lib/charms/k8s/v0/k8sd_api_manager.py     278     29    90%
src/charm.py                              500    260    48%
src/cloud_integration.py                   80      3    96%
src/config/extra_args.py                   29      2    93%
src/containerd.py                         140     22    84%
src/cos_integration.py                     33     12    64%
src/events/update_status.py                68     24    65%
src/inspector.py                           41      4    90%
src/kube_control.py                        43     32    26%
src/literals.py                            23      0   100%
src/protocols.py                           28      5    82%
src/reschedule.py                          77      4    95%
src/snap.py                               193     30    84%
src/token_distributor.py                  181    109    40%
src/upgrade.py                            108     48    56%
-----------------------------------------------------------
TOTAL                                    1822    584    68%
coverage-report: OK (1.44=setup[1.19]+cmd[0.25] seconds)
congratulations :) (1.61 seconds)

Static code analysis report

Run started:2025-01-14 18:12:40.703509

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3876
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@addyess addyess merged commit 44f15e8 into release-1.32 Jan 16, 2025
70 checks passed
@addyess addyess deleted the backport/224/release-1.32 branch January 16, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants