Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up changes applied to 1.32-release branch #225

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Dec 19, 2024

Overview

During #223, changes were made in that release branch to produce better upgrade results. This lifts those changes back to main

Details

* Pin snap_installations to 1.32-classic stables
* Upgrade from the 1.32-classic channel
* Test upgrading from 1.32/beta to locally built charms
* build upgrade list from the upgrade relation
* Unify channel and revision snap installation
* Remove snap override feature
* Run test_upgrade only if a charm track exists to upgrade from
@addyess addyess requested a review from a team as a code owner December 19, 2024 19:36
Copy link
Contributor

Test coverage for 1e7377a

coverage-report: install_deps /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> python -I -m pip install 'coverage[toml]'
coverage-report: commands[0] /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> coverage report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
lib/charms/k8s/v0/k8sd_api_manager.py     278     29    90%
src/charm.py                              500    260    48%
src/cloud_integration.py                   80      3    96%
src/config/extra_args.py                   29      2    93%
src/containerd.py                         140     22    84%
src/cos_integration.py                     33     12    64%
src/events/update_status.py                68     24    65%
src/inspector.py                           41      4    90%
src/kube_control.py                        39     31    21%
src/literals.py                            23      0   100%
src/protocols.py                           28      5    82%
src/reschedule.py                          77      4    95%
src/snap.py                               193     29    85%
src/token_distributor.py                  181    109    40%
src/upgrade.py                            108     48    56%
-----------------------------------------------------------
TOTAL                                    1818    582    68%
coverage-report: OK (1.27=setup[1.06]+cmd[0.22] seconds)
congratulations :) (1.32 seconds)

Static code analysis report

Run started:2024-12-19 19:38:04.987142

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3864
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@addyess addyess merged commit 9b9c0a0 into main Dec 19, 2024
70 checks passed
@addyess addyess deleted the KU-2360/cherry-pick-to-main branch December 19, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants