New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add worker node clustering #17

Merged

addyess merged 1 commit into main from KU-304/worker-clustering

Feb 12, 2024

Contributor

bschimke95 commented Feb 6, 2024 •

edited

Loading

Overview

Enables support for adding k8s-worker charms to the cluster.

Library Changes

Update k8s-snap API calls to use the unified endpoints for token generation and joining a cluster
Replace k8s-snap CLI invocation for clustering with direct API call
Add unittest/integration test coverage

bschimke95 force-pushed the KU-304/worker-clustering branch from aa7a93d to dd7b4af Compare

February 6, 2024 15:18

bschimke95 marked this pull request as ready for review

February 7, 2024 08:07

bschimke95 requested a review from a team as a code owner

February 7, 2024 08:07

addyess requested changes

View reviewed changes

Contributor

addyess left a comment

I have questions about the token generated by create_join_token about whether it can be used by both workers and control-plane, or if they must be different based on the role.

Also, you've gotta distribute the tokens to both workers and control-planes

charms/worker/k8s/lib/charms/k8s/v0/k8sd_api_manager.py Show resolved Hide resolved

charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved

charms/worker/k8s/src/charm.py Show resolved Hide resolved

charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved

charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved

charms/worker/k8s/lib/charms/k8s/v0/k8sd_api_manager.py Outdated Show resolved Hide resolved

addyess reviewed

View reviewed changes

charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved

addyess reviewed

View reviewed changes

charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved

bschimke95 commented

View reviewed changes

charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved

bschimke95 force-pushed the KU-304/worker-clustering branch 3 times, most recently from 8091f18 to e820132 Compare

February 9, 2024 16:25

addyess requested changes

View reviewed changes

Contributor

addyess left a comment

Sad, we can't count on the application name in juju being known.

charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved

addyess force-pushed the KU-304/worker-clustering branch from aad1498 to 335a467 Compare

February 9, 2024 23:03

addyess reviewed

View reviewed changes

charms/worker/k8s/src/charm.py Show resolved Hide resolved

addyess reviewed

View reviewed changes

charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved

addyess force-pushed the KU-304/worker-clustering branch from 2b81869 to 14658f0 Compare

February 10, 2024 12:42


          Add worker node clustering

379a8c8

Enable support for adding k8s-worker charms to the cluster
by integrating the k8s:k8s-cluster and k8s-worker:cluster relations.

bschimke95 force-pushed the KU-304/worker-clustering branch from 7106a13 to 379a8c8 Compare

February 12, 2024 07:27

bschimke95 requested a review from addyess

February 12, 2024 12:46

addyess approved these changes

View reviewed changes

Contributor

addyess left a comment

LGTM

addyess merged commit 5cff9cc into main

21 checks passed

addyess deleted the KU-304/worker-clustering branch

February 12, 2024 13:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet