Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jhack nuke -m test not removing the model #210

Open
swetha1654 opened this issue Mar 30, 2025 · 6 comments
Open

jhack nuke -m test not removing the model #210

swetha1654 opened this issue Mar 30, 2025 · 6 comments

Comments

@swetha1654
Copy link
Contributor

Bug Description

jhack nuke -m testing runs the command without any errors but does not remove the model.

To Reproduce

  1. juju add-model testing
  2. jhack nuke -m testing or jhack nuke --model testing

Environment

No response

Relevant log output

Here is the output of the command with `loglevel` set to `INFO`:

(venv) user@myubuntu:~/Canonical/jhack$(main)jhack --loglevel=INFO nuke -m testing
::= Verbose mode (INFO). =::
INFO:jhack.nuke:starting jhack nuke

Additional context

No response

@PietroPasotti
Copy link
Collaborator

interestingly, this issue only appears in the snapped version. I'd also expect the debug logger to print something more than it does. Not sure what's going on. Perhaps a typer version mismatch?

@swetha1654
Copy link
Contributor Author

For me, the issue occurs not just in the snap version but also in the Git repo cloned version as well

@PietroPasotti
Copy link
Collaborator

huh that's surprising. Can you share a pip freeze of the venv you're using?
do you see any logs when you run with LOGLEVEL=DEBUG?

@swetha1654
Copy link
Contributor Author

This is all i see when i run it with loglevel=debug

(venv) user@myubuntu:~/Canonical/jhack$(main)jhack --loglevel=DEBUG nuke -m testing
::= Verbose mode (DEBUG). =::
INFO:jhack.nuke:starting jhack nuke
(venv) user@myubuntu:~/Canonical/jhack$(main)

This is the output of pip freeze -

(venv) user@myubuntu:~/Canonical/old/jhack$(main)pip freeze
asttokens==3.0.0
astunparse==1.6.3
black==25.1.0
certifi==2025.1.31
charset-normalizer==3.4.1
click==8.1.8
idna==3.10
-e git+https://github.com/canonical/jhack.git@81b1ea1acd0c9857d78a081f26cec3498be27354#egg=jhack
markdown-it-py==2.2.0
mdurl==0.1.2
mypy-extensions==1.0.0
ops==2.17.1
ops-scenario==7.0.5
packaging==24.2
parse==1.19.0
pathspec==0.12.1
platformdirs==4.3.7
Pygments==2.19.1
PyYAML==6.0.2
requests==2.29.0
requests-unixsocket==0.3.0
rich==13.3.0
six==1.17.0
toml==0.10.2
tomli==2.2.1
typer==0.7.0
typing_extensions==4.13.0
urllib3==1.25
websocket-client==1.8.0

@PietroPasotti
Copy link
Collaborator

you have an extremely old typer. Can you upgrade it to 0.15 and see if that makes a difference?

@swetha1654
Copy link
Contributor Author

You're right, upgrading it to the latest version of typer seems to work. Let me update my PR with the change. Thanks!

PietroPasotti added a commit that referenced this issue Apr 2, 2025
Fix for #210 (`jhack nuke -m test` not removing the model)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants