Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use pull_request_target for cla-check #88

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

troyanov
Copy link
Member

When run on the pull_request_target event, has-signed-canonical-cla action will also comment on the PR if any authors have not signed the CLA, and update those messages when new commits or runs are processed.

When run on the `pull_request_target` event, `has-signed-canonical-cla` action
will also comment on the PR if any authors have not signed the CLA, and update
those messages when new commits or runs are processed.
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this change is not needed. I am ok to either include it or not :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is an intended one, just to improve file readability (and have the common pattern to name things with - as delimiter between words)

@troyanov troyanov merged commit f41b3c4 into canonical:master Jul 17, 2024
3 checks passed
@troyanov troyanov deleted the fix-workflow branch July 17, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants